Using code actions with Omnisharp does not modify buffer #1322

mcraveiro · 2023-11-18T18:47:43Z

mcraveiro
Nov 18, 2023

Hi,

I recently moved over to eglot from lsp-mode and thus far I am rather pleased with the experience - thanks very much for all your hard work. I have one minor problem though, which I am pretty sure is something to do with my environment / setup. For some reason, whenever I try to use code actions, eglot "appears" to perform it but no changes are actually made to my buffer.

My setup is as follows:

Operative System: Windows 10
LSP server: Omnisharp 1.39
Emacs: 29.1
Programming language: C# (csharp-mode)

In general, all features I have used in eglot have worked thus far. When I ask for code actions, I get a list of actions and they look sensible (i.e. if I "perform" the action myself, it solves my problem so the LSP server is returning a good answer). I tried toggling debug on error but nothing came up. I also see nothing in my messages buffer. I am not the most knowledgeable person with regards to Emacs lisp, unfortunately. Can you suggest some ways to obtain more information as to where things are going wrong please?

Many thanks for your time.

Marco

mcraveiro · 2023-11-25T09:44:44Z

mcraveiro
Nov 25, 2023
Author

I just noticed that renaming also does not seem to do anything. I wonder if there is some kind of issue with the paths coming out of Omnisharp and Emacs is not able to find the files in order to perform the operations. The commands in the eglot log look perfectly sensible, at least.

0 replies

mcraveiro · 2024-03-07T17:48:00Z

mcraveiro
Mar 7, 2024
Author

This problem still persists. I will try to see if I can edebug the issue.

0 replies

mcraveiro · 2024-03-07T18:14:48Z

mcraveiro
Mar 7, 2024
Author

Debugging did not reveal anything obvious, but that may just be due to my lack of Emacs Lisp knowledge. I am now trying to understand how the LSP flow should work. I had a look at the LSP docs on this [1]. It seems one requests the server for a set of possible actions, which the server replies with, but I am not yet clear if we need to execute the code action locally (i.e. by eglot) or if its something the LSP server will do for us (i.e. omnisharp).

[1] https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction

0 replies

mcraveiro · 2024-03-07T18:37:36Z

mcraveiro
Mar 7, 2024
Author

Its still not clear to me where the actions are executing, but I have created a test program to observe the message flow:

using System;

namespace dotnet {
    class Program {
        static xvoid some() {
        }

        static void Main(string[] args) {
            Console.WriteLine("Hello World!");
            some();
        }
    }
}

As expected, I get the code actions up:

If I select the second option, the following messages are observed:

[client-request] (id:3) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 3 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 8)))
[client-request] (id:4) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 4 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 8)))
[client-request] (id:5) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 5 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 8)))
[server-reply] (id:3) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 3 :result nil)
[server-reply] (id:4) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 4 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 8. | "))
[server-reply] (id:5) Thu Mar  7 18:31:20 2024:
(:jsonrpc "2.0" :id 5 :result
          [])
[client-request] (id:6) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 6 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 9)))
[client-request] (id:7) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 7 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 9)))
[client-request] (id:8) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 8 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 9)))
[server-reply] (id:6) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 6 :result nil)
[server-reply] (id:7) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 7 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 9. | "))
[server-reply] (id:8) Thu Mar  7 18:31:26 2024:
(:jsonrpc "2.0" :id 8 :result
          [])
[client-request] (id:9) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 9 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:10) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 10 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:11) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 11 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[server-reply] (id:9) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 9 :result nil)
[server-reply] (id:10) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 10 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 16. | "))
[server-reply] (id:11) Thu Mar  7 18:31:36 2024:
(:jsonrpc "2.0" :id 11 :result
          [])
[client-request] (id:12) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 12 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 12)))
[client-request] (id:13) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 13 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 12)))
[client-request] (id:14) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 14 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 12)))
[server-reply] (id:12) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 12 :result nil)
[server-reply] (id:13) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 13 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 12. | "))
[server-reply] (id:14) Thu Mar  7 18:31:39 2024:
(:jsonrpc "2.0" :id 14 :result
          [])
[client-request] (id:15) Thu Mar  7 18:31:42 2024:
(:jsonrpc "2.0" :id 15 :method "textDocument/codeAction" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :range
           (:start
            (:line 4 :character 8)
            :end
            (:line 4 :character 15))
           :context
           (:diagnostics
            [])))
[server-reply] (id:15) Thu Mar  7 18:31:43 2024:
(:jsonrpc "2.0" :id 15 :result
          [])
[client-request] (id:16) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 16 :method "textDocument/codeAction" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :range
           (:start
            (:line 4 :character 16)
            :end
            (:line 4 :character 20))
           :context
           (:diagnostics
            [(:range
              (:start
               (:line 4 :character 16)
               :end
               (:line 4 :character 20))
              :severity 1 :code "CS1519" :source "csharp" :message "Invalid token 'void' in class, record, struct, or interface member declaration" :tags
              [])])))
[server-reply] (id:16) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 16 :result
          [])
[client-request] (id:17) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 17 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[client-request] (id:18) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 18 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[client-request] (id:19) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 19 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[server-reply] (id:17) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 17 :result nil)
[server-reply] (id:18) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 18 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 17. | "))
[server-reply] (id:19) Thu Mar  7 18:31:46 2024:
(:jsonrpc "2.0" :id 19 :result
          [])
[client-notification] Thu Mar  7 18:31:48 2024:
(:jsonrpc "2.0" :method "workspace/didChangeWatchedFiles" :params
          (:changes
           [(:uri "file:///home/some-user/some-dir/dotnet/[email protected]%3A1709827983" :type 1)]))
[client-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "textDocument/didChange" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs" :version 2)
           :contentChanges
           [(:text "using System;\n\nnamespace dotnet {\n    class Program {\n        static xvoid some() {\n\n\n        }\n\n        static void Main(string[] args) {\n            Console.WriteLine(\"Hello World!\");\n            Console.WriteLine(\"test\");\n            some();\n        }\n    }\n}\n")]))
[client-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "textDocument/didSave" :params
          (:text "using System;\n\nnamespace dotnet {\n    class Program {\n        static xvoid some() {\n\n\n        }\n\n        static void Main(string[] args) {\n            Console.WriteLine(\"Hello World!\");\n            Console.WriteLine(\"test\");\n            some();\n        }\n    }\n}\n" :textDocument
                 (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")))
[client-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "workspace/didChangeWatchedFiles" :params
          (:changes
           [(:uri "file:///home/some-user/some-dir/dotnet/Program.cs" :type 2)]))
[client-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "workspace/didChangeWatchedFiles" :params
          (:changes
           [(:uri "file:///home/some-user/some-dir/dotnet/.%23Program.cs" :type 3)]))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 0 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 1 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 0 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 1 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 0 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 1 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 0 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 2 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 1 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 3 :message "OmniSharp.Roslyn.CSharp.Services.Diagnostics.CSharpDiagnosticWorkerWithAnalyzers: Analyzer work cancelled. | "))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 2 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 1 :ProjectFilePath "(100%)"))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 3 :message "OmniSharp.Roslyn.CSharp.Services.Diagnostics.CSharpDiagnosticWorkerWithAnalyzers: Analyzer work cancelled. | "))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "textDocument/publishDiagnostics" :params
          (:uri "file:///home/some-user/some-dir/dotnet/Program.cs" :version 0 :diagnostics
                [(:range
                  (:start
                   (:line 4 :character 15)
                   :end
                   (:line 4 :character 20))
                  :severity 1 :code "CS0246" :source "csharp" :message "The type or namespace name 'xvoid' could not be found (are you missing a using directive or an assembly reference?)" :tags
                  [])
                 (:range
                  (:start
                   (:line 4 :character 21)
                   :end
                   (:line 4 :character 25))
                  :severity 1 :code "CS0161" :source "csharp" :message "'Program.some()': not all code paths return a value" :tags
                  [])]))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/backgrounddiagnosticstatus" :params
          (:Status 2 :NumberProjects 1 :NumberFilesTotal 1 :NumberFilesRemaining 0))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "o#/projectdiagnosticstatus" :params
          (:Type "background" :Status 1 :ProjectFilePath "(100%)"))
[client-request] (id:20) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 20 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:21) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 21 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:22) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 22 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:23) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 23 :method "textDocument/inlayHint" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :range
           (:start
            (:line 4 :character 0)
            :end
            (:line 16 :character 0))))
[server-reply] (id:20) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 20 :result nil)
[server-reply] (id:21) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 21 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 16. | "))
[server-reply] (id:22) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 22 :result
          [])
[server-reply] (id:23) Thu Mar  7 18:31:50 2024:
(:jsonrpc "2.0" :id 23 :result
          [])
[client-request] (id:24) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 24 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[client-request] (id:25) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 25 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[client-request] (id:26) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 26 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[server-reply] (id:24) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 24 :result nil)
[server-reply] (id:25) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 25 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 5, Column: 0. | "))
[server-reply] (id:26) Thu Mar  7 18:31:51 2024:
(:jsonrpc "2.0" :id 26 :result
          [])
[client-request] (id:27) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 27 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:28) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 28 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[client-request] (id:29) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 29 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 16)))
[server-reply] (id:27) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 27 :result nil)
[server-reply] (id:28) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 28 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 16. | "))
[server-reply] (id:29) Thu Mar  7 18:31:52 2024:
(:jsonrpc "2.0" :id 29 :result
          [])
[client-request] (id:30) Thu Mar  7 18:31:53 2024:
(:jsonrpc "2.0" :id 30 :method "textDocument/codeAction" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :range
           (:start
            (:line 4 :character 15)
            :end
            (:line 4 :character 20))
           :context
           (:diagnostics
            [(:range
              (:start
               (:line 4 :character 15)
               :end
               (:line 4 :character 20))
              :severity 1 :code "CS0246" :source "csharp" :message "The type or namespace name 'xvoid' could not be found (are you missing a using directive or an assembly reference?)" :tags
              [])])))
[server-reply] (id:30) Thu Mar  7 18:31:53 2024:
(:jsonrpc "2.0" :id 30 :result
          [(:title "Generate type 'xvoid' -> Generate class 'xvoid' in new file" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate class 'xvoid' in new file" :Name "Generate type 'xvoid' -> Generate class 'xvoid' in new file" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Generate type 'xvoid' -> Generate class 'xvoid'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate class 'xvoid'" :Name "Generate type 'xvoid' -> Generate class 'xvoid'" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Generate type 'xvoid' -> Generate nested class 'xvoid'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate nested class 'xvoid'" :Name "Generate type 'xvoid' -> Generate nested class 'xvoid'" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Change 'xvoid' to 'void'." :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "void" :Name "Change 'xvoid' to 'void'." :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))])
[client-request] (id:31) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 31 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[client-request] (id:32) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 32 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[client-request] (id:33) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 33 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[server-reply] (id:31) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 31 :result nil)
[server-reply] (id:32) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 32 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 0. | "))
[server-reply] (id:33) Thu Mar  7 18:32:33 2024:
(:jsonrpc "2.0" :id 33 :result
          [])
[client-request] (id:34) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 34 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 3 :character 0)))
[client-request] (id:35) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 35 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 3 :character 0)))
[client-request] (id:36) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 36 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 3 :character 0)))
[server-reply] (id:34) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 34 :result nil)
[server-reply] (id:35) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 35 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 3, Column: 0. | "))
[server-reply] (id:36) Thu Mar  7 18:32:36 2024:
(:jsonrpc "2.0" :id 36 :result
          [])
[client-request] (id:37) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 37 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 16 :character 0)))
[client-request] (id:38) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 38 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 16 :character 0)))
[client-request] (id:39) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 39 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 16 :character 0)))
[server-reply] (id:37) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 37 :result nil)
[server-reply] (id:38) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 38 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 16, Column: 0. | "))
[server-reply] (id:39) Thu Mar  7 18:32:39 2024:
(:jsonrpc "2.0" :id 39 :result
          [])
[client-request] (id:40) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 40 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 7 :character 9)))
[client-request] (id:41) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 41 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 7 :character 9)))
[client-request] (id:42) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 42 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 7 :character 9)))
[server-reply] (id:40) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 40 :result nil)
[server-reply] (id:41) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 41 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 7, Column: 9. | "))
[server-reply] (id:42) Thu Mar  7 18:33:36 2024:
(:jsonrpc "2.0" :id 42 :result
          [])
[client-request] (id:43) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 43 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[client-request] (id:44) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 44 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[client-request] (id:45) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 45 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 5 :character 0)))
[server-reply] (id:43) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 43 :result nil)
[server-reply] (id:44) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 44 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 5, Column: 0. | "))
[server-reply] (id:45) Thu Mar  7 18:33:38 2024:
(:jsonrpc "2.0" :id 45 :result
          [])
[client-request] (id:46) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 46 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[client-request] (id:47) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 47 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[client-request] (id:48) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 48 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 0)))
[server-reply] (id:46) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 46 :result nil)
[server-reply] (id:47) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 47 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 0. | "))
[server-reply] (id:48) Thu Mar  7 18:33:40 2024:
(:jsonrpc "2.0" :id 48 :result
          [])
[client-request] (id:49) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 49 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 6 :character 0)))
[client-request] (id:50) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 50 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 6 :character 0)))
[client-request] (id:51) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 51 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 6 :character 0)))
[server-reply] (id:49) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 49 :result nil)
[server-reply] (id:50) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 50 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 6, Column: 0. | "))
[server-reply] (id:51) Thu Mar  7 18:33:51 2024:
(:jsonrpc "2.0" :id 51 :result
          [])
[client-request] (id:52) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 52 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[client-request] (id:53) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 53 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[client-request] (id:54) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 54 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 17)))
[server-reply] (id:52) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 52 :result nil)
[server-reply] (id:53) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 53 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 17. | "))
[server-reply] (id:54) Thu Mar  7 18:33:52 2024:
(:jsonrpc "2.0" :id 54 :result
          [])
[client-request] (id:55) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 55 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 0 :character 0)))
[client-request] (id:56) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 56 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 0 :character 0)))
[client-request] (id:57) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 57 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 0 :character 0)))
[server-reply] (id:55) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 55 :result nil)
[server-reply] (id:56) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 56 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 0, Column: 0. | "))
[server-reply] (id:57) Thu Mar  7 18:33:59 2024:
(:jsonrpc "2.0" :id 57 :result
          [])
[client-request] (id:58) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 58 :method "textDocument/signatureHelp" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 18)))
[client-request] (id:59) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 59 :method "textDocument/hover" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 18)))
[client-request] (id:60) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 60 :method "textDocument/documentHighlight" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :position
           (:line 4 :character 18)))
[server-reply] (id:58) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 58 :result nil)
[server-reply] (id:59) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 59 :result
          (:contents
           (:kind "markdown" :value "")))
[server-notification] Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :method "window/logMessage" :params
          (:type 2 :message "OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService: No symbol found. File: /home/some-user/some-dir/dotnet/Program.cs, Line: 4, Column: 18. | "))
[server-reply] (id:60) Thu Mar  7 18:34:03 2024:
(:jsonrpc "2.0" :id 60 :result
          [])
[client-request] (id:61) Thu Mar  7 18:34:14 2024:
(:jsonrpc "2.0" :id 61 :method "textDocument/codeAction" :params
          (:textDocument
           (:uri "file:///home/some-user/some-dir/dotnet/Program.cs")
           :range
           (:start
            (:line 4 :character 15)
            :end
            (:line 4 :character 20))
           :context
           (:diagnostics
            [])))
[server-reply] (id:61) Thu Mar  7 18:34:14 2024:
(:jsonrpc "2.0" :id 61 :result
          [(:title "Generate type 'xvoid' -> Generate class 'xvoid' in new file" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate class 'xvoid' in new file" :Name "Generate type 'xvoid' -> Generate class 'xvoid' in new file" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Generate type 'xvoid' -> Generate class 'xvoid'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate class 'xvoid'" :Name "Generate type 'xvoid' -> Generate class 'xvoid'" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Generate type 'xvoid' -> Generate nested class 'xvoid'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "Generate nested class 'xvoid'" :Name "Generate type 'xvoid' -> Generate nested class 'xvoid'" :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))
           (:title "Change 'xvoid' to 'void'." :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/some-user/some-dir/dotnet/Program.cs" :Identifier "void" :Name "Change 'xvoid' to 'void'." :Range
                         (:Start
                          (:Line 4 :Character 15)
                          :End
                          (:Line 4 :Character 20))
                         :$$__handler_id__$$ "dae05ab3-043d-4999-9ea3-5e44b9972e94"))])

I still haven't managed to make complete sense of the messages, but here they are in case anyone else is able to.

0 replies

mcraveiro · 2024-03-07T19:02:43Z

mcraveiro
Mar 7, 2024
Author

After debugging, I now believe the issue is with the server rather than eglot. I have raised an issue with Omnisharp:

OmniSharp/omnisharp-roslyn#2607

I'll update this ticket with any additional information.

2 replies

mcraveiro Mar 17, 2024
Author

I created a discussion on reddit on this topic [1]. Whilst I have not found a solution as such, it did allow me to understand a bit better the problem. According to user vecksagos, omnisharp should have sent a message with the required edits and then eglot should apply those edits to the buffer via eglot--apply-text-edits. I edebuged that method and it does not appear to get called. I also see no evidence in the eglot event log of a response sent by omnisharp. I am now convinced this is an omnisharp issue.

[1] https://www.reddit.com/r/emacs/comments/1447fy2/looking_for_help_in_improving_typescript_eglot/

mcraveiro Mar 17, 2024
Author

Actually, I think what is required is a way to see the omnisharp server log. At present I have been relying on eglot's event log but if I understood things correctly, this is the client log. Trying to find out of there is a way within eglot to display the server log.

joaotavora · 2024-03-17T12:36:34Z

joaotavora
Mar 17, 2024
Maintainer

On Sun, Mar 17, 2024, 10:12 Marco Craveiro ***@***.***> wrote: Actually, I think what is required is a way to see the omnisharp server log. At present I have been relying on eglot's event log but if I understood things correctly, this is the client log. Trying to find out of there is a way within eglot to display the server log.

Eglot's event buffer is the log of the LSP conversation that took place between two posts. It also has internal Eglot messages that are not part of the conversation. These are like Eglot thought balloons. If the server spews additional logging information on stderr, also not part of the conversation, it should nevertheless also appear there, like server thought balloons. The Clangd does this logging to stderr to great effects and it is very useful information to debug server behaviour. If the server spews logging information anywhere else other than stderr, it is up to you to consult the documentation and go find it. João

1 reply

mcraveiro Mar 18, 2024
Author

Aha most interesting, obrigado João. However I'm afraid I am still slightly confused, so I'll ask a couple of follow on questions:

Eglot's event buffer is the log of the LSP conversation that took place between two posts.

But presumably these are all of the LSP messages received by the client right? I'm afraid I don't fully understand how LSP works so this may be a stupid question :-)

If the server spews additional logging information on stderr, also not part of the conversation, it should nevertheless also appear there, like server thought balloons.

Most excellent. But what if the server incorrectly puts an error message in stdout? I think that is what would happen with plain C# logging, though I need to test this hypothesis.

joaotavora · 2024-03-18T09:26:13Z

joaotavora
Mar 18, 2024
Maintainer

But presumably these are all of the LSP messages received by the client right? I'm afraid I don't fully understand how LSP works so this may be a stupid question :-)

First, I don't know what I wrote "posts": it's probably auto-correct on my phone. I meant "parts". And no these are not aonly the LSP message received by the client, they are also the LSP message sent by the client. Here's the very beginning of the conversation of Eglot with a clangd session. There are many types of message illustrated here:

[jsonrpc] D[09:13:13.595] Running language server: clangd --query-driver=**
[jsonrpc] e[09:13:13.597] --> initialize[1] {"jsonrpc":"2.0","id":1,"method":"initialize","params":{"processId":16612,"clientInfo":{"name":"Eglot"},"rootPath":"c:/Users/jatav/tmp/","rootUri":"file:///c%3A/Users/jatav/tmp","initializationOptions":{},"capabilities":{"workspace":{"applyEdit":true,"executeCommand":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":false},"configuration":true,"workspaceFolders":true},"textDocument":{"synchronization":{"dynamicRegistration":false,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":false,"completionItem":{"snippetSupport":true,"deprecatedSupport":true,"resolveSupport":{"properties":["documentation","details","additionalTextEdits"]},"tagSupport":{"valueSet":[1]}},"contextSupport":true},"hover":{"dynamicRegistration":false,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":false,"signatureInformation":{"parameterInformation":{"labelOffsetSupport":true},"documentationFormat":["markdown","plaintext"],"activeParameterSupport":true}},"references":{"dynamicRegistration":false},"definition":{"dynamicRegistration":false,"linkSupport":true},"declaration":{"dynamicRegistration":false,"linkSupport":true},"implementation":{"dynamicRegistration":false,"linkSupport":true},"typeDefinition":{"dynamicRegistration":false,"linkSupport":true},"documentSymbol":{"dynamicRegistration":false,"hierarchicalDocumentSymbolSupport":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]}},"documentHighlight":{"dynamicRegistration":false},"codeAction":{"dynamicRegistration":false,"resolveSupport":{"properties":["edit","command"]},"dataSupport":true,"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"isPreferredSupport":true},"formatting":{"dynamicRegistration":false},"rangeFormatting":{"dynamicRegistration":false},"rename":{"dynamicRegistration":false},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"relatedInformation":false,"codeDescriptionSupport":false,"tagSupport":{"valueSet":[1,2]}}},"window":{"showDocument":{"support":true},"workDoneProgress":true},"general":{"positionEncodings":["utf-32","utf-8","utf-16"]},"experimental":{}},"workspaceFolders":[{"uri":"file:///c%3A/Users/jatav/tmp","name":"~/tmp/"}]}}
[stderr]  I[09:13:14.049] clangd version 16.0.5
[stderr]  I[09:13:14.050] Features: windows
[stderr]  I[09:13:14.050] PID: 8536
[stderr]  I[09:13:14.050] Working directory: c:/Users/jatav/tmp
[stderr]  I[09:13:14.050] argv[0]: c:\Users\jatav\Vendor\msys64\mingw64\bin\clangd.exe
[stderr]  I[09:13:14.050] argv[1]: --query-driver=**
[stderr]  I[09:13:14.054] Starting LSP over stdin/stdout
[stderr]  I[09:13:14.055] <-- initialize(1)
[jsonrpc] e[09:13:14.076] <-- initialize[1] {"id":1,"jsonrpc":"2.0","result":{"capabilities":{"astProvider":true,"callHierarchyProvider":true,"clangdInlayHintsProvider":true,"codeActionProvider":{"codeActionKinds":["quickfix","refactor","info"]},"compilationDatabase":{"automaticReload":true},"completionProvider":{"resolveProvider":false,"triggerCharacters":[".","<",">",":","\"","/","*"]},"declarationProvider":true,"definitionProvider":true,"documentFormattingProvider":true,"documentHighlightProvider":true,"documentLinkProvider":{"resolveProvider":false},"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"\n","moreTriggerCharacter":[]},"documentRangeFormattingProvider":true,"documentSymbolProvider":true,"executeCommandProvider":{"commands":["clangd.applyFix","clangd.applyTweak"]},"foldingRangeProvider":true,"hoverProvider":true,"implementationProvider":true,"inlayHintProvider":true,"memoryUsageProvider":true,"referencesProvider":true,"renameProvider":true,"selectionRangeProvider":true,"semanticTokensProvider":{"full":{"delta":true},"legend":{"tokenModifiers":["declaration","definition","deprecated","deduced","readonly","static","abstract","virtual","dependentName","defaultLibrary","usedAsMutableReference","usedAsMutablePointer","constructorOrDestructor","userDefined","functionScope","classScope","fileScope","globalScope"],"tokenTypes":["variable","variable","parameter","function","method","function","property","variable","class","interface","enum","enumMember","type","type","unknown","namespace","typeParameter","concept","type","macro","modifier","operator","comment"]},"range":false},"signatureHelpProvider":{"triggerCharacters":["(",")","{","}","<",">",","]},"standardTypeHierarchyProvider":true,"textDocumentSync":{"change":2,"openClose":true,"save":true},"typeDefinitionProvider":true,"typeHierarchyProvider":true,"workspaceSymbolProvider":true},"serverInfo":{"name":"clangd","version":"clangd version 16.0.5 windows x86_64-w64-windows-gnu"}}}
[jsonrpc] e[09:13:14.076] --> initialized {"jsonrpc":"2.0","method":"initialized","params":{}}
[jsonrpc] e[09:13:14.080] --> textDocument/didOpen {"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///c%3A/Users/jatav/tmp/coiso.c","version":0,"languageId":"c","text":""}}}
[jsonrpc] e[09:13:14.083] --> workspace/didChangeConfiguration {"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{}}}

Every message prefixed [stderr] is a server though balloon. A [jsonrpc] D message is a client thought baloon. The remaining [jsonrpc] messages are either incoming or outgoing (from the perspective of the client) LSP messages in the conversation.

But what if the server incorrectly puts an error message in stdout? I think that is what would happen with plain C# logging, though I need to test this hypothesis.

If the server does that and the client will pick it up as part of the LSP conversation. if it's not intended as part of this protocol, the communication will likely fail at that point. It could even tear down the connction entirely.

0 replies

joaotavora · 2024-03-18T09:35:17Z

joaotavora
Mar 18, 2024
Maintainer

(I changed the title of this discussion slightly because it could be interpreted as expecting the code actions make "current buffer" to change to another buffer)

0 replies

mcraveiro · 2024-03-18T15:11:13Z

mcraveiro
Mar 18, 2024
Author

aha, wow muito obrigado for all the info, its starting to make sense now! So then with this new understanding, when I look at the last code actions message:

[server-reply] (id:5) Mon Mar 18 14:57:39 2024:
(:jsonrpc "2.0" :id 5 :result
          [(:title "Generate variable 'xConsole' -> Generate field 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate field 'xConsole'" :Name "Generate variable 'xConsole' -> Generate field 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate variable 'xConsole' -> Generate read-only field 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate read-only field 'xConsole'" :Name "Generate variable 'xConsole' -> Generate read-only field 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate variable 'xConsole' -> Generate property 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate property 'xConsole'" :Name "Generate variable 'xConsole' -> Generate property 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate variable 'xConsole' -> Generate local 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate variable 'xConsole' -> Generate local 'xConsole'" :Name "Generate variable 'xConsole' -> Generate local 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate variable 'xConsole' -> Generate parameter 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate variable 'xConsole' -> Generate parameter 'xConsole'" :Name "Generate variable 'xConsole' -> Generate parameter 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate type 'xConsole' -> Generate class 'xConsole' in new file" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate class 'xConsole' in new file" :Name "Generate type 'xConsole' -> Generate class 'xConsole' in new file" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate type 'xConsole' -> Generate class 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate class 'xConsole'" :Name "Generate type 'xConsole' -> Generate class 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Generate type 'xConsole' -> Generate nested class 'xConsole'" :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Generate nested class 'xConsole'" :Name "Generate type 'xConsole' -> Generate nested class 'xConsole'" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Change 'xConsole' to 'Console'." :kind "quickfix" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Console" :Name "Change 'xConsole' to 'Console'." :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Extract method" :kind "refactor.extract" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Extract_method" :Name "Extract method" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))
           (:title "Extract local function" :kind "refactor.extract" :diagnostics
                   []
                   :data
                   (:Uri "file:///home/user/dotnet/Program.cs" :Identifier "Extract_local_function" :Name "Extract local function" :Range
                         (:Start
                          (:Line 12 :Character 12)
                          :End
                          (:Line 12 :Character 20))
                         :$$__handler_id__$$ "2e314f16-b735-46d8-ab39-2c20ee0d8960"))])

This is after I select a code action to apply. Shouldn't there be another message after this? For the specific selection I made from the list. I tried looking at the clangd event log to compare, but unfortunately for some reason it thinks there are no code actions available at all:

[client-request] (id:12) Mon Mar 18 15:10:23 2024:
(:jsonrpc "2.0" :id 12 :method "textDocument/codeAction" :params
          (:textDocument
           (:uri "file:///home/user/main.cpp")
           :range
           (:start
            (:line 7 :character 8)
            :end
            (:line 7 :character 13))
           :context
           (:diagnostics
            [])))
[server-reply] (id:12) Mon Mar 18 15:10:23 2024:
(:id 12 :jsonrpc "2.0" :result
     [])
[stderr] I[15:10:23.330] <-- textDocument/codeAction(12)
[stderr] I[15:10:23.331] --> reply:textDocument/codeAction(12) 0 ms

I wonder if there is a bigger problem with my setup.

12 replies

mcraveiro Mar 19, 2024
Author

Excellent news!! I think we are close! I added the following to my config:

(defun cunene/path-to-omnisharp ()
  "Returns the path to the LSP server for C#."
  (if (eq window-system 'w32)
      "c:/some_windows_path/omnisharp-roslyn/OmniSharp.exe"
    "/home/some_linux_path/omnisharp/OmniSharp.exe"))

(add-to-list 'eglot-server-programs
             `(csharp-mode . (,(cunene/path-to-omnisharp) "-lsp")))

mcraveiro Mar 20, 2024
Author

I've posted a question to the Omnisharp guys on this, to see if this is intended or not [1]. Meanwhile, I am trying to read the spec to understand it a bit better [2]. This in particular got my attention:

export interface [CodeAction](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#codeAction) {

	/**
	 * A short, human-readable, title for this code action.
	 */
	title: string;
<snip>
      /**
	 * The workspace edit this code action performs.
	 */
	edit?: [WorkspaceEdit](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspaceEdit);

	/**
	 * A command this code action executes. If a code action
	 * provides an edit and a command, first the edit is
	 * executed and then the command.
	 */
	command?: [Command](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#command);

Do I read this right in that both edit and command are nullable / optional? The spec is not easy to parse for laypeople unfortunately. And if both are optional, what is the client expected to do? :-D

[1] OmniSharp/omnisharp-roslyn#2607
[2] https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction

joaotavora Mar 20, 2024
Maintainer

Do I read this right in that both edit and command are nullable / optional?

Yes, they are. But I think it doesn't make sense:

~~to provide both~~ (EDIT actually this does make sense, it's specifically expressed in the spec, don't think I've ever see it)
to provide none

It's just that the spec doesn't have any method of expressing ~~XOR~~, OR.

And if both are optional, what is the client expected to do? :-D

Right, I don't know. But maybe I am misunderstanding something.

mcraveiro Mar 20, 2024
Author

Okeydokey. Lets see what the Omnisharp people say then... Not much you can do at the client side right. Though, the question then must be "what does Visual Studio Code do" right. Because I can't believe this feature does not work on VS Code! :-)

joaotavora Mar 20, 2024
Maintainer

Though, the question then must be "what does Visual Studio Code do" right. Because I can't believe this feature does not work on VS Code! :-)

Sigh. Yes. Likely VSCode has some extra-LSP stuff, which is typical.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using code actions with Omnisharp does not modify buffer #1322

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 9 comments 15 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

Using code actions with Omnisharp does not modify buffer #1322

mcraveiro Nov 18, 2023

Replies: 9 comments · 15 replies

mcraveiro Nov 25, 2023 Author

mcraveiro Mar 7, 2024 Author

mcraveiro Mar 7, 2024 Author

mcraveiro Mar 7, 2024 Author

mcraveiro Mar 7, 2024 Author

mcraveiro Mar 17, 2024 Author

mcraveiro Mar 17, 2024 Author

joaotavora Mar 17, 2024 Maintainer

mcraveiro Mar 18, 2024 Author

joaotavora Mar 18, 2024 Maintainer

joaotavora Mar 18, 2024 Maintainer

mcraveiro Mar 18, 2024 Author

mcraveiro Mar 19, 2024 Author

mcraveiro Mar 20, 2024 Author

joaotavora Mar 20, 2024 Maintainer

mcraveiro Mar 20, 2024 Author

joaotavora Mar 20, 2024 Maintainer

mcraveiro
Nov 18, 2023

Replies: 9 comments 15 replies

mcraveiro
Nov 25, 2023
Author

mcraveiro
Mar 7, 2024
Author

mcraveiro
Mar 7, 2024
Author

mcraveiro
Mar 7, 2024
Author

mcraveiro
Mar 7, 2024
Author

mcraveiro Mar 17, 2024
Author

mcraveiro Mar 17, 2024
Author

joaotavora
Mar 17, 2024
Maintainer

mcraveiro Mar 18, 2024
Author

joaotavora
Mar 18, 2024
Maintainer

joaotavora
Mar 18, 2024
Maintainer

mcraveiro
Mar 18, 2024
Author

mcraveiro Mar 19, 2024
Author

mcraveiro Mar 20, 2024
Author

joaotavora Mar 20, 2024
Maintainer

mcraveiro Mar 20, 2024
Author

joaotavora Mar 20, 2024
Maintainer