Skip to content

Typescript Code-Actions Do Nothing #1225

Answered by joaotavora
tarjeiba asked this question in Q&A
Discussion options

You must be logged in to vote

I believe this was just a typo. Can you check if this fixes it?

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index cd5831efc48..0140db0c4b3 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -741,7 +741,7 @@ eglot-execute
      (((Command)) (eglot--request server :workspace/executeCommand action))
      (((CodeAction) edit command)
       (when edit (eglot--apply-workspace-edit edit))
-      (when command (eglot--request server :workspace/executeCommand action))))))
+      (when command (eglot--request server :workspace/executeCommand command))))))
 
 (cl-defgeneric eglot-initialization-options (server)
   "JSON object to send under `initializationOpti…

Replies: 6 comments 9 replies

Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
3 replies
@joaotavora
Comment options

@tarjeiba
Comment options

@tarjeiba
Comment options

Comment options

You must be logged in to vote
1 reply
@tarjeiba
Comment options

Comment options

You must be logged in to vote
5 replies
@joaotavora
Comment options

@tarjeiba
Comment options

@mpenet
Comment options

@joaotavora
Comment options

@mpenet
Comment options

Answer selected by tarjeiba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
3 participants