Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: string is not seen as a valid input #409

Open
EinfachHans opened this issue Jun 21, 2024 · 2 comments
Open

bug: string is not seen as a valid input #409

EinfachHans opened this issue Jun 21, 2024 · 2 comments
Labels
bug date-fns issue Waiting for date-fns to fix an issue

Comments

@EinfachHans
Copy link

Description of the Issue and Steps to Reproduce:

Since date-fns@3 a string is a valid input as date. With the dfns pipes it is not:

export type DateFnsInputDate = number | Date;

Environment:

Please answer the following questions:

  • Angular version: 18
  • TypeScript version: 5.4.5
  • date-fns version: 3.6.0
@joanllenas
Copy link
Owner

Thanks for letting me know @EinfachHans.
I'll look into this soon.

@joanllenas joanllenas added the bug label Jun 24, 2024
@joanllenas
Copy link
Owner

joanllenas commented Jul 3, 2024

@EinfachHans It seems there's an issue with date-fns supporting string as a valid input.
I was implementing the fix and found that a few end-to-end tests were failing, so I started investigating and discovered this bug report in their repo: date-fns/date-fns#3710.
We'll have to wait until they fix to get proper support.

@joanllenas joanllenas added the date-fns issue Waiting for date-fns to fix an issue label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug date-fns issue Waiting for date-fns to fix an issue
Projects
None yet
Development

No branches or pull requests

2 participants