From 90f7297d953505cd7222a21d0fa20d1ece8eb827 Mon Sep 17 00:00:00 2001 From: Pontus Lurcock Date: Fri, 27 Nov 2020 14:34:59 +0100 Subject: [PATCH] Comment changes to AppCeyor config --- appveyor.yml | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 70cc693d..c8d6d8c5 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -16,8 +16,9 @@ environment: JPY_PYTHON_HOME_UBUNTU: /home/appveyor/venv3.4 JPY_MAC_PYTHON_VERSION: 3.4.10 # Python 3.4 is incompatible with OpenSSL 1.1, so we have to force the - # installation of OpenSSL 1.0 (see https://bugs.python.org/issue31838 - # and https://gist.github.com/souzagab/0ae60e61939d51385de87904b65b2da2 ). + # installation of OpenSSL 1.0 (see https://bugs.python.org/issue31838 , + # https://gist.github.com/souzagab/0ae60e61939d51385de87904b65b2da2 , + # and more detailed comments below). JPY_MAC_OPENSSL_PACKAGE: openssl.rb - JPY_PYTHON_HOME_WINDOWS: C:\Python35-x64 JPY_PYTHON_HOME_UBUNTU: /home/appveyor/venv3.5 @@ -112,15 +113,22 @@ for: # use brew to install pyenv and pyenv to install a 10.9-targeted Python # environment. # + - brew update # The Python 3.4 Mac build is particularly challenging, because Python 3.4 # is incompatible with OpenSSL 1.1, and OpenSSL 1.0 is no longer supported - # by homebrew. We install OpenSSL 1.0 by directly specifying the URL of - # the appropriate homebrew formula, set a lot of environment variables to - # make sure that pyenv can find it, then uninstall version 1.1. (For the - # Python 3.8 build, OpenSSL 1.1 is then automatically reinstalled by pyenv.) - # Most of this configuration can be removed once we drop Python 3.4 support. - - brew update + # by homebrew. We install OpenSSL 1.0 by explicitly fetching the 1.0 + # formula from an old revision in the homebrew repository and installing + # from the downloaded file. Then we set a lot of environment variables to + # make sure that pyenv can find the newly installed openssl and uninstall + # version 1.1. (For the Python >3.4 builds, OpenSSL 1.1 is then + # automatically reinstalled by pyenv.) Most of this configuration can be + # removed once we drop Python 3.4 support. + # + # As of October 2020, "brew install" forbids installation of openssl from + # a GitHub commit URL, so we fetch it with curl and install from the file. - curl https://raw.githubusercontent.com/Homebrew/homebrew-core/64555220bfbf4a25598523c2e4d3a232560eaad7/Formula/openssl.rb > openssl.rb + # For Python 3.4, $JPY_MAC_OPENSSL_PACKAGE should contain the name of the + # downloaded file; for newer Pythons, "openssl@1.1". - brew install -f $JPY_MAC_OPENSSL_PACKAGE - brew install pyenv - export ssldir=/usr/local/opt/openssl