Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is "pausing script" supposed to work? #25

Open
bzbarsky opened this issue Nov 2, 2017 · 2 comments
Open

How is "pausing script" supposed to work? #25

bzbarsky opened this issue Nov 2, 2017 · 2 comments

Comments

@bzbarsky
Copy link

bzbarsky commented Nov 2, 2017

https://github.com/jkarlin/pause-document#pause-details says:

When script is paused, any running script task is completed and future tasks on the event queue (e.g., events (including WebSocket) and timers) remain queued until the document is unpaused.

But "the event queue" is shared by multiple documents, some of which may have script paused and some may not. This needs a much clearer explanation of how things are expected to work.

@jkarlin
Copy link
Owner

jkarlin commented Nov 2, 2017

I'll specify that this is targeting tasks related to the given frame in the event queue.

@bzbarsky
Copy link
Author

bzbarsky commented Nov 2, 2017

"related to the given frame" will need to be defined.

For example, if script in window A does new windowB.WebSocket, are the events for that websocket related to A or B?

jkarlin added a commit that referenced this issue Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants