Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favorite 기능관련 버튼 커스텀화 / 추상화하기 #32

Open
jinios opened this issue Sep 9, 2018 · 0 comments
Open

Favorite 기능관련 버튼 커스텀화 / 추상화하기 #32

jinios opened this issue Sep 9, 2018 · 0 comments
Assignees
@jinios
Labels
refactor need to refactor
Milestone
step-new-favorite

Comments

@jinios
Copy link
Owner

jinios commented Sep 9, 2018

  • Favorite을 on / off하고 해당 상태를 표시하는 별 버튼이 사용되는 곳이 많아서, 추상화하고 한 타입으로 사용하기
@jinios jinios added the refactor need to refactor label Sep 9, 2018
@jinios jinios added this to the step-new-favorite milestone Sep 9, 2018
@jinios jinios self-assigned this Sep 9, 2018
jinios added a commit that referenced this issue Sep 14, 2018
@jinios
Refactor: Add StarButton file #32
2b486aa
jinios added a commit that referenced this issue Sep 14, 2018
@jinios
Refactor: Add StarButton custom type, FavoriteTogglable #32
d7b9e24 
- Delete extension of UIButton for features to set favorite
- Make custom type of UIButton - StarButton
- Add protocol for features to set and toggle favorite
jinios added a commit that referenced this issue Sep 14, 2018
@jinios
Refactor: Implement FavoriteTogglable protocol #32
a9c2850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinios jinios

Labels
refactor need to refactor
Projects
None yet
Milestone
step-new-favorite
Development

No branches or pull requests
1 participant
@jinios