-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent accidental file:// usage #8
Comments
I added this code right after the
|
@nyurik can you open a PR adding these functionality? |
@jieter, I don't think mine is the right approach - my code implies that the user will have to do something like this:
whereas I think users should be able to do this:
|
@nyurik any interest in adding something to fix this? I've no personal need for it, so cannot invest the time implementing it. PR's still welcome of course. |
In some cases when this module is used with unsanitized data (possibly by accident), the ability to access "file://" is a major security issue. Please add a flag to explicitly permit file:// access, which IMO should be
false
by default. Also, please provide for an easy way to inject my own URL sanitization function right before that URL is being used. Thanks!The text was updated successfully, but these errors were encountered: