Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with optional path parameter names #35

Open
alexbrad opened this issue Apr 17, 2013 · 0 comments
Open

Problem with optional path parameter names #35

alexbrad opened this issue Apr 17, 2013 · 0 comments

Comments

@alexbrad
Copy link

When using optional path parameters with Backbone.Router.namedParameters = true, the extracted parameter name includes the trailing ')' or the starting '(' of a subsequent optional paramter.

The problem can be solved by changing the namedPattern regexp from
/:*/g to /:*/g

All tests pass after the change (except test 263, which was failing anyway).

Should I make a pull request, considering that the change is extremely simple?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant