Merge pull request #11983 from qmonmert/varinstead

Sonar: Local-Variable Type Inference should be used
jhipster · Feb 24, 2025 · b14846f · b14846f
2 parents 54fd46d + b9152a1
commit b14846f
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 21 deletions.
diff --git a/...n/java/tech/jhipster/lite/shared/error/infrastructure/primary/AssertionErrorsHandler.java b/...n/java/tech/jhipster/lite/shared/error/infrastructure/primary/AssertionErrorsHandler.java
@@ -37,7 +37,7 @@ public AssertionErrorsHandler(@Qualifier("assertionErrorMessageSource") MessageS
   @ExceptionHandler(AssertionException.class)
   ProblemDetail handleAssertionError(AssertionException exception) {
     HttpStatus status = buildStatus(exception);
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
+    var problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
 
     problem.setTitle(getMessage(exception.type(), "title"));
     problem.setProperty("key", exception.type().name());

diff --git a/...a/tech/jhipster/lite/shared/error/infrastructure/primary/BeanValidationErrorsHandler.java b/...a/tech/jhipster/lite/shared/error/infrastructure/primary/BeanValidationErrorsHandler.java
@@ -25,7 +25,7 @@ class BeanValidationErrorsHandler {
 
   @ExceptionHandler(MethodArgumentNotValidException.class)
   ProblemDetail handleMethodArgumentNotValid(MethodArgumentNotValidException exception) {
-    ProblemDetail problem = buildProblemDetail();
+    var problem = buildProblemDetail();
     problem.setProperty(ERRORS, buildErrors(exception));
 
     log.info(exception.getMessage(), exception);
@@ -43,7 +43,7 @@ private Map<String, String> buildErrors(MethodArgumentNotValidException exceptio
 
   @ExceptionHandler(ConstraintViolationException.class)
   ProblemDetail handleConstraintViolationException(ConstraintViolationException exception) {
-    ProblemDetail problem = buildProblemDetail();
+    var problem = buildProblemDetail();
     problem.setProperty(ERRORS, buildErrors(exception));
 
     log.info(exception.getMessage(), exception);
@@ -52,10 +52,7 @@ ProblemDetail handleConstraintViolationException(ConstraintViolationException ex
   }
 
   private ProblemDetail buildProblemDetail() {
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(
-      HttpStatus.BAD_REQUEST,
-      "One or more fields were invalid. See 'errors' for details."
-    );
+    var problem = ProblemDetail.forStatusAndDetail(HttpStatus.BAD_REQUEST, "One or more fields were invalid. See 'errors' for details.");
 
     problem.setTitle("Bean validation error");
     return problem;
@@ -70,7 +67,7 @@ private Map<String, String> buildErrors(ConstraintViolationException exception)
 
   private Function<ConstraintViolation<?>, String> toFieldName() {
     return error -> {
-      String propertyPath = error.getPropertyPath().toString();
+      var propertyPath = error.getPropertyPath().toString();
 
       return propertyPath.substring(propertyPath.lastIndexOf('.') + 1);
     };

diff --git a/...n/java/tech/jhipster/lite/shared/error/infrastructure/primary/GeneratorErrorsHandler.java b/...n/java/tech/jhipster/lite/shared/error/infrastructure/primary/GeneratorErrorsHandler.java
@@ -35,7 +35,7 @@ public GeneratorErrorsHandler(@Qualifier("generatorErrorMessageSource") MessageS
   @ExceptionHandler(GeneratorException.class)
   ProblemDetail handleGeneratorException(GeneratorException exception) {
     HttpStatus status = Optional.ofNullable(Enums.map(exception.status(), HttpStatus.class)).orElse(HttpStatus.INTERNAL_SERVER_ERROR);
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
+    var problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
 
     problem.setTitle(getMessage(exception.key(), "title"));
     problem.setProperty("key", exception.key().get());

diff --git a/...java/tech/jhipster/lite/wire/security/infrastructure/primary/CorsFilterConfiguration.java b/...java/tech/jhipster/lite/wire/security/infrastructure/primary/CorsFilterConfiguration.java
@@ -22,7 +22,7 @@ public CorsFilterConfiguration(CorsConfiguration corsConfiguration) {
 
   @Bean
   public CorsFilter corsFilter() {
-    UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource();
+    var source = new UrlBasedCorsConfigurationSource();
     if (
       !CollectionUtils.isEmpty(corsConfiguration.getAllowedOrigins()) ||
       !CollectionUtils.isEmpty(corsConfiguration.getAllowedOriginPatterns())

diff --git a/...erver/springboot/mvc/internationalized-errors/main/ApplicationErrorsHandler.java.mustache b/...erver/springboot/mvc/internationalized-errors/main/ApplicationErrorsHandler.java.mustache
@@ -35,7 +35,7 @@ class {{ baseName }}ErrorsHandler {
   @ExceptionHandler({{ baseName }}Exception.class)
   ProblemDetail handle{{ baseName }}Exception({{ baseName }}Exception exception) {
     HttpStatus status = Optional.ofNullable(Enums.map(exception.status(), HttpStatus.class)).orElse(HttpStatus.INTERNAL_SERVER_ERROR);
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
+    var problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
 
     problem.setTitle(getMessage(exception.key(), "title"));
     problem.setProperty("key", exception.key().get());

diff --git a/.../server/springboot/mvc/internationalized-errors/main/AssertionErrorsHandler.java.mustache b/.../server/springboot/mvc/internationalized-errors/main/AssertionErrorsHandler.java.mustache
@@ -37,7 +37,7 @@ class AssertionErrorsHandler {
   @ExceptionHandler(AssertionException.class)
   ProblemDetail handleAssertionError(AssertionException exception) {
     HttpStatus status = buildStatus(exception);
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
+    var problem = ProblemDetail.forStatusAndDetail(status, buildDetail(exception));
 
     problem.setTitle(getMessage(exception.type(), "title"));
     problem.setProperty("key", exception.type().name());

diff --git a/...c/security/common/main/infrastructure/primary/AuthenticationExceptionAdvice.java.mustache b/...c/security/common/main/infrastructure/primary/AuthenticationExceptionAdvice.java.mustache
@@ -17,7 +17,7 @@ class AuthenticationExceptionAdvice {
 
   @ExceptionHandler(NotAuthenticatedUserException.class)
   public ProblemDetail handleNotAuthenticateUser(NotAuthenticatedUserException ex) {
-    ProblemDetail detail = ProblemDetail.forStatus(HttpStatus.UNAUTHORIZED);
+    var detail = ProblemDetail.forStatus(HttpStatus.UNAUTHORIZED);
     detail.setTitle("not authenticated");
     detail.setProperty(MESSAGE_KEY, "error.http.401");
 
@@ -26,7 +26,7 @@ class AuthenticationExceptionAdvice {
 
   @ExceptionHandler(UnknownAuthenticationException.class)
   public ProblemDetail handleUnknownAuthentication(UnknownAuthenticationException ex) {
-    ProblemDetail detail = ProblemDetail.forStatus(HttpStatus.INTERNAL_SERVER_ERROR);
+    var detail = ProblemDetail.forStatus(HttpStatus.INTERNAL_SERVER_ERROR);
     detail.setTitle("unknown authentication");
     detail.setProperty(MESSAGE_KEY, "error.http.500");
 

diff --git a/...gboot/mvc/security/jwt/authentication/main/infrastructure/primary/JwtReader.java.mustache b/...gboot/mvc/security/jwt/authentication/main/infrastructure/primary/JwtReader.java.mustache
@@ -46,7 +46,7 @@ class JwtReader implements AuthenticationTokenReader {
   }
 
   private Optional<Authentication> parseToken(String token) {
-    Claims claims = parser.parseSignedClaims(token).getPayload();
+    var claims = parser.parseSignedClaims(token).getPayload();
 
     List<SimpleGrantedAuthority> authorities = readAuthorities(claims);
 

diff --git a/.../security/jwt/basic-auth/main/infrastructure/primary/AuthenticationResource.java.mustache b/.../security/jwt/basic-auth/main/infrastructure/primary/AuthenticationResource.java.mustache
@@ -34,7 +34,7 @@ class AuthenticationResource {
   public ResponseEntity<RestToken> authorize(@Valid @RequestBody RestAuthenticationQuery authenticationQuery) {
     Token token = authenticator.authenticate(authenticationQuery);
 
-    HttpHeaders httpHeaders = new HttpHeaders();
+    var httpHeaders = new HttpHeaders();
     httpHeaders.add(HttpHeaders.AUTHORIZATION, token.bearer());
 
     return new ResponseEntity<>(RestToken.from(token), httpHeaders, HttpStatus.OK);

diff --git a/...ources/generator/server/springboot/mvc/web/main/BeanValidationErrorsHandler.java.mustache b/...ources/generator/server/springboot/mvc/web/main/BeanValidationErrorsHandler.java.mustache
@@ -25,7 +25,7 @@ class BeanValidationErrorsHandler {
 
   @ExceptionHandler(MethodArgumentNotValidException.class)
   ProblemDetail handleMethodArgumentNotValid(MethodArgumentNotValidException exception) {
-    ProblemDetail problem = buildProblemDetail();
+    var problem = buildProblemDetail();
     problem.setProperty(ERRORS, buildErrors(exception));
 
     log.info(exception.getMessage(), exception);
@@ -43,7 +43,7 @@ class BeanValidationErrorsHandler {
 
   @ExceptionHandler(ConstraintViolationException.class)
   ProblemDetail handleConstraintViolationException(ConstraintViolationException exception) {
-    ProblemDetail problem = buildProblemDetail();
+    var problem = buildProblemDetail();
     problem.setProperty(ERRORS, buildErrors(exception));
 
     log.info(exception.getMessage(), exception);
@@ -52,7 +52,7 @@ class BeanValidationErrorsHandler {
   }
 
   private ProblemDetail buildProblemDetail() {
-    ProblemDetail problem = ProblemDetail.forStatusAndDetail(
+    var problem = ProblemDetail.forStatusAndDetail(
       HttpStatus.BAD_REQUEST,
       "One or more fields were invalid. See 'errors' for details."
     );
@@ -70,7 +70,7 @@ class BeanValidationErrorsHandler {
 
   private Function<ConstraintViolation<?>, String> toFieldName() {
     return error -> {
-      String propertyPath = error.getPropertyPath().toString();
+      var propertyPath = error.getPropertyPath().toString();
 
       return propertyPath.substring(propertyPath.lastIndexOf(".") + 1);
     };

diff --git a/...urces/generator/server/springboot/mvc/web/main/cors/CorsFilterConfiguration.java.mustache b/...urces/generator/server/springboot/mvc/web/main/cors/CorsFilterConfiguration.java.mustache
@@ -22,7 +22,7 @@ class CorsFilterConfiguration {
 
   @Bean
   public CorsFilter corsFilter() {
-    UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource();
+    var source = new UrlBasedCorsConfigurationSource();
     if (
       !CollectionUtils.isEmpty(corsConfiguration.getAllowedOrigins()) ||
       !CollectionUtils.isEmpty(corsConfiguration.getAllowedOriginPatterns())