Heroku generator update.

[mshima]

Overview of the feature request

There is some discussion about heroku generator future at #19551.
A proposal to drop it was done at #19112.
@mraible wants to keep support for it #19112 (comment).
And following the comment I agree we should keep it, because old tutorials may be outdated but they keep around forever.
Keeping good promoting materials valid (or near) is good for JHipster.

Blueprints overrides heroku too (dotnetcore, micronaut).

Current heroku implementation is too complicated and uses outdated standards. New need to:

• replace child_process with this.spawn[Command][Sync].
• drop run-async with async function.
• simplify.

Motivation for or Use Case

Related issues or PR

• Checking this box is mandatory (this is just to show you read everything)

[mraible]

I'll see if I can bribe @deepu105 into helping me with this next week when we're together at Devoxx Belgium. 😉

[deepu105]

I haven't used Heroku in a loooong time. I'll check it out this weekend and see what I can do

…

On Fri, 29 Sept 2023, 6:42 pm Matt Raible, ***@***.***> wrote: I'll see if I can bribe @deepu105 <https://github.com/deepu105> into helping me with this next week when we're together at Devoxx Belgium. 😉 — Reply to this email directly, view it on GitHub <#23686 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIOKFYAV6FFYQ3NZ3P5QPTX4327PANCNFSM6AAAAAA5MUTCTQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mraible]

@mshima Do you have an example of these refactorings in another sub-generator? Otherwise, I'll just be doing a find-and-replace and hoping things work. It looks like tests will need to change too, since there's code like this:

  beforeEach(() => {
    stub = sinon.stub(ChildProcess, 'exec');
    stub.withArgs('heroku --version').yields(false);
    stub.withArgs('heroku plugins').yields(false, 'heroku-cli-deploy');
    stub.withArgs('git init').yields([false, '', '']);
  });
  afterEach(() => {
    // eslint-disable-next-line @typescript-eslint/no-explicit-any
    (ChildProcess.exec as any).restore();
  });

[mshima]

You can see spawnMocks here:
f6e9d38

To simulate spawn return create a sinon stub:

const stub = sinon.stub();
stub.withArgs('spawnCommand', 'heroku --version').yields(false);

note that spawnCommand can be one of spawn/spawnSync/spawnCommand/spawnCommandSync, the one you used to call the specific command.

and inject:

helpers
  …
  .withSpawnMock(stub)
  …;

[mshima]

Is there microservice stack support?
If no I think ci-cd generator can be used as base.
The ci-cd rework is implemented at https://github.com/jhipster/generator-jhipster/pull/23718/files

[mraible]

@mshima There isn't support for deploying a whole microservices stack, but there is support for individual apps. @jdubois published a tutorial on Heroku's blog in 2016 that shows how to do it.

[mraible]

@mshima I took a pass at updating the Heroku generator in #23971. I'm not sure I did this one correctly:

• drop run-async with async function