Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Made With Bulma displays Incorrect badges. #3965

Open
abp1994 opened this issue Feb 7, 2025 · 5 comments
Open

[Docs] Made With Bulma displays Incorrect badges. #3965

abp1994 opened this issue Feb 7, 2025 · 5 comments

Comments

@abp1994
Copy link

abp1994 commented Feb 7, 2025

I have noticed that the Bulma badges referenced on the documentation "made with bulma" page are not showing correctly- (https://bulma.io/made-with-bulma/)

The 6 versions of the badge are shown correctly in the first section as shown below.

Image

However in the second section which shows how to embed the badges directly, labeled "Badge Snippets", all the badges are shown as the default rather than the variant. (see below)

Image

To fix this each image needs to be referencing its correct badge version and the associated snippets of code needs to be updated to reflect this too.

As an example: The white made with bulma badge needs to be updated to the "made-with-bulma--white.png" image and in the code snippet src="https://bulma.io/assets/images/made-with-bulma.png" needs to be changed to to src="https://bulma.io/assets/images/made-with-bulma--white.png"

@abp1994 abp1994 changed the title Made With Bulma Docs displays Incorrect badges. [Docs] Made With Bulma displays Incorrect badges. Feb 7, 2025
@jgthms
Copy link
Owner

jgthms commented Feb 7, 2025

The second part is only to showcase the default badge in context of certain backgrounds. If you feel like it should use other badges, feel free to make a pull request and I'll merge it.

@abp1994
Copy link
Author

abp1994 commented Feb 8, 2025

Sure thing!

The colour contrast isn't very good on Transparent white and turquoise badge on it's background when it is in this section (see below)

Image

Should I change it to a solid colour as shown below, if so do you have a colour you would like?

Image

Lemme know what you think.

@jgthms
Copy link
Owner

jgthms commented Feb 8, 2025

I'd rather keep the original background but keep the default badge.

@abp1994
Copy link
Author

abp1994 commented Feb 8, 2025

I think the code will end up quite messy if only a single box in the "#Usage" section has tweaks. At the moment it works nicely just refferencing the code from the table above. It's probably best the small and large image backgrounds stay identical for the sake of not overcomplicating things.

Image

In my opinion the best options are:

  1. Change both background images to another image that has better contrast.
  2. Change both background images to a colour
  3. Swap the background images around between themselves to find a better pairing.
  4. Do nothing and leave it as is (inspite of all 6 example code snippets being the identical)
  5. Accept the change with the suboptimal contrast (keeping the original background image),

happy to do whichever

@abp1994
Copy link
Author

abp1994 commented Feb 8, 2025

Here is one possibility -

Image

let me know what combinations of badge and background image you want in each section and I can implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants