Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ITT handle #24

Open
VladLupashevskyi opened this issue Feb 5, 2021 · 4 comments
Open

Implementation of ITT handle #24

VladLupashevskyi opened this issue Feb 5, 2021 · 4 comments

Comments

@VladLupashevskyi
Copy link
Contributor

It's not possible currently to open the KI209 file because of missing implementation of ITT handle.

@jglim
Copy link
Owner

jglim commented Feb 5, 2021

Hi VladLupashevskyi,

Thanks for the bug report. I can confirm the issue on KI209, specifically for the Datensatz_Service parameter in VCD_Complete_Oildata_Service. For now I don't think I can deliver a proper fix as this looks like a fairly tricky issue; if service records are not in your objectives, maybe I can temporarily downgrade the exception to a warning.

Affected VCFragments / VCDomains (repeated data from different KI variants):

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service

Datensatz_Service  %0%0%[340/0]
VCD Name: VCD_Complete_Oildata_Service_fix

@VladLupashevskyi
Copy link
Contributor Author

Hi @jglim,
Thanks for a quick reply!

I think it would make sense to downgrade the exception to a warning, so other functions can be accessible.
It would be great from UX perspective to provide a warning message which says that not all functions are available now.

Cheers

@jglim
Copy link
Owner

jglim commented Feb 5, 2021

I hear your feedback; my earlier strategy was to "crash loudly" if anything was amiss, but having an option to continue (carefully) is indeed better.

I have made changes so that it prints warnings without throwing an exception. For now, there isn't enough changes to tag a new release so here's a zipped build in case you want to try it quickly.

CaesarSuite_dbg_2021-02-05-A.zip

image

@VladLupashevskyi
Copy link
Contributor Author

@jglim That's cool :) Thank you very much 👍

I think the issue should stay opened since the main problem is not solved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants