Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build aggregation does not work when when trying to aggregate builds that include special characters such as '/' and ':' #2043

Closed
YonatanHen opened this issue Jun 27, 2023 · 3 comments · Fixed by jfrog/jfrog-cli-core#1020
Labels
bug Something isn't working

Comments

@YonatanHen
Copy link

YonatanHen commented Jun 27, 2023

Describe the bug

Build aggregation does not work (return 404 error) when trying to aggregate builds that include special characters such as '/' and ':'. (It can be seen that special characters are replaced with the encoded value in the UI, so it might be the cause of this issue).

Current behavior

jf rt build-append new-build 2 'a:b' 1
13:22:18 [Debug] JFrog CLI version: 2.34.3
13:22:18 [Debug] OS/Arch: darwin/arm64
13:22:18 [:large_blue_circle:Info] Running Build Append command...
13:22:18 [Debug] Saving build general details at: /var/folders/1c/_y26p04d0xg_q8y9mrhxpqxr0000gn/T/jfrog/builds/6396556063ea34e7f27e36d169c96723061ae27e28d0b7097699c5c521c42161/partials
13:22:18 [Debug] Getting build-info from:  http://<url>/artifactory/api/build/a:b/1
13:22:18 [Debug] Sending HTTP GET request to: http://<url>/artifactory/api/build/a:b/1
13:22:18 [Debug] Usage Report: Sending info...
13:22:18 [Debug] Sending HTTP GET request to: http://<url>/artifactory/api/system/version
13:22:18 [Debug] Artifactory response: 200 OK
13:22:18 [Debug] JFrog Artifactory version is: 7.59.9
13:22:18 [Debug] Sending HTTP POST request to: http://<url>/artifactory/api/system/usage
13:22:18 [Debug] Build a:b/1. Started: 2023-06-21T13:22:04.016+0300. Calculated timestamp: 1687342924016
13:22:18 [Debug] Sending HTTP HEAD request to: http://<url>/artifactory/artifactory-build-info/a:b/1-1687342924016.json
13:22:18 [Debug] Usage Report: Artifactory response: 200 OK
13:22:18 [Debug] Usage Report: Usage info sent successfully.
13:22:18 [:rotating_light:Error] server response: 404 Not Found

Reproduction steps

  1. Publish a build with special characters to your Artifactory instance.
  2. Run the Aggregating Published Builds CLI command using the published build.

For instance:

jf rt build-append new-build 1 a/b 41
jf rt build-append new-build 1 'a :: b' 42
jf rt bp new-build 1

Expected behavior

The build aggregation command should work for any build name.

JFrog CLI version

2.34.3

Operating system type and version

MacOS/Linux

JFrog Artifactory version

7.33.12,7.55.7

JFrog Xray version

No response

@YonatanHen YonatanHen added the bug Something isn't working label Jun 27, 2023
@sarao1310
Copy link
Contributor

Hello, @YonatanHen! We appreciate your report and apologize for any inconvenience caused. You can keep track of the progress on this matter through the following Jira issue: https://jfrog.atlassian.net/browse/RTFACT-29749https://jfrog.atlassian.net/browse/RTFACT-29749
Thank you for bringing this to our attention!

@DavidRadoorHummel
Copy link

@sarao1310 the JIRA ticket you linked is unrelated to the issue posted here.

@yahavi
Copy link
Member

yahavi commented Nov 19, 2023

@YonatanHen
JFrog CLI 2.51.1 has been released.
This version includes the fix for this issue.
We'd appreciate your feedback on that!

@RobiNino RobiNino closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants