From 296600d31ae3ad300c35d0d9eba457a35bdb8850 Mon Sep 17 00:00:00 2001 From: oshratz Date: Thu, 14 Nov 2024 13:27:59 +0200 Subject: [PATCH] Turn the signing key to be optional in RBC --- lifecycle/cli.go | 4 ---- lifecycle/cli_test.go | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lifecycle/cli.go b/lifecycle/cli.go index 92a7a5d0e..d45068b4e 100644 --- a/lifecycle/cli.go +++ b/lifecycle/cli.go @@ -127,10 +127,6 @@ func validateCreateReleaseBundleContext(c *cli.Context) error { return cliutils.WrongNumberOfArgumentsHandler(c) } - if err := assertSigningKeyProvided(c); err != nil { - return err - } - return assertValidCreationMethod(c) } diff --git a/lifecycle/cli_test.go b/lifecycle/cli_test.go index 65b911958..a09ac6e91 100644 --- a/lifecycle/cli_test.go +++ b/lifecycle/cli_test.go @@ -21,7 +21,7 @@ func TestValidateCreateReleaseBundleContext(t *testing.T) { {"extraArgs", []string{"one", "two", "three", "four"}, []string{}, true}, {"bothSources", []string{"one", "two", "three"}, []string{cliutils.Builds + "=/path/to/file", cliutils.ReleaseBundles + "=/path/to/file"}, true}, {"noSources", []string{"one", "two", "three"}, []string{}, true}, - {"builds without signing key", []string{"name", "version"}, []string{cliutils.Builds + "=/path/to/file"}, true}, + {"builds without signing key", []string{"name", "version"}, []string{cliutils.Builds + "=/path/to/file"}, false}, {"builds correct", []string{"name", "version"}, []string{ cliutils.Builds + "=/path/to/file", cliutils.SigningKey + "=key"}, false}, {"releaseBundles without signing key", []string{"name", "version", "env"}, []string{cliutils.ReleaseBundles + "=/path/to/file"}, true},