Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UID? #54

Open
JoeThielen opened this issue Dec 8, 2015 · 2 comments · May be fixed by #226
Open

Add UID? #54

JoeThielen opened this issue Dec 8, 2015 · 2 comments · May be fixed by #226

Comments

@JoeThielen
Copy link

Hello, thanks for the project, I think it's great, almost perfect for what I'm looking for.

Can we get UID added as a supported property?

I just basically duplicated the addURL() method for my own use. But I'm a bit confused on what to put in the comment for $type... I think "UUID" would be relevant, but more explanation on the issue can be found at the following link, and I'm curious as to your thoughts.
http://microformats.org/wiki/vcard-errata#3.6.7_UID_Type_Definition

I'm new to GitHub, but I think I can submit the code. However, in reading your README.md file regarding contribution, I see you ask for unit tests, which I've never done. I'm looking at tests/VCardTest.php, would I be able to just duplicate the testAddUrl() method and edit it appropriately? Or is there a different and/or better way?
@JoeThielen
Copy link
Author

I'd also like to add the ROLE property. In the RFC I don't see that it supports any parameters or anything, So for this I think duplicating the addNote() method would work.

@jeroendesloovere
Copy link
Owner

Hi @JoeThielen,

A pull request with your changed code would be awesome.

UnitTests:
Yes, just duplicate an existing one an add some "true" and maby "false" validations.

@lkmorlan lkmorlan linked a pull request Aug 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create VCard::addUid() lkmorlan/vcard
2 participants
@jeroendesloovere @JoeThielen