Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uneede currency #5

Open
Scoubines opened this issue Apr 13, 2020 · 5 comments
Open

Remove uneede currency #5

Scoubines opened this issue Apr 13, 2020 · 5 comments

Comments

@Scoubines
Copy link

The workflow is awesome but I would like to remove the currencies I don't need, because now I can't have a glimspe of all results without having to scroll. Would that be possible to have a customization feature in it??

Many thanks!

@levifig
Copy link

levifig commented May 14, 2020

I'm on the same boat. I think most people are to: they want to drop a number (should accept currency symbol or initials, btw, like "347 eur" or "347€"), and immediately get the results in the few currencies they are interested in.

Also, another suggestion: allow me to set "favorite currencies". The way I see it is with two at most: you do "curconv 347" and you get both way conversions on your favorite ones. So, using the example above, "curconv 347", it would give me both "347 eur = 376 usd" and "347 usd = 320 eur". You kinda do it already but using the descrition of a result, which is way less visible and doesn't get its own flag icon (making it a LOT less readable).

@jeppestaerk
Copy link
Owner

@sammy-nes and @levifig thank you for inputs, you are welcome to make a pull request.

@Scoubines
Copy link
Author

@jeppestaerk Thank you! That would make just perfect!
I'm looking forward to it!

@levifig
Copy link

levifig commented May 19, 2020

@jeppestaerk Thank you! That would make just perfect!
I'm looking forward to it!

@sammy-nes From @jeppestaerk's reply, I'm pretty sure he isn't planning on making the changes and is tossing the ball to anyone else who is willing to do it and submit a pull request! :) Just making sure you don't get overly excited… ;)

@custardcream98
Copy link
Contributor

@sammy-nes @levifig Hi, I've added this feature. You can get it here
It's pretty long time ago, but if you still willing to use this feature, please feel free to give me feedback😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants