From f60b7e3928aa02182b6d82b8563a8544d15f6625 Mon Sep 17 00:00:00 2001
From: Antoine Musso <hashar@free.fr>
Date: Fri, 18 Oct 2024 11:23:37 +0200
Subject: [PATCH] Reuse completed build result

Instead of invoking `completedRun.getResult()` several times, invoke it
once and reuse the resust. That makes the code slightly easier to read.
---
 .../plugins/parameterizedtrigger/TriggerBuilder.java     | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java b/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
index cb278fe4..46baff43 100644
--- a/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
+++ b/src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
@@ -179,20 +179,21 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
                                                 + " started.");
 
                                 Run completedRun = future.get();
+                                Result completedResult = completedRun.getResult();
                                 listener.getLogger()
                                         .println(HyperlinkNote.encodeTo(
                                                         '/' + completedRun.getUrl(),
                                                         completedRun.getFullDisplayName())
-                                                + " completed. Result was " + completedRun.getResult());
+                                                + " completed. Result was " + completedResult);
                                 BuildInfoExporterAction.addBuildInfoExporterAction(
                                         build,
                                         completedRun.getParent().getFullName(),
                                         completedRun.getNumber(),
-                                        completedRun.getResult());
+                                        completedResult);
 
                                 if (buildStepResult
-                                        && config.getBlock().mapBuildStepResult(completedRun.getResult())) {
-                                    Result r = config.getBlock().mapBuildResult(completedRun.getResult());
+                                        && config.getBlock().mapBuildStepResult(completedResult)) {
+                                    Result r = config.getBlock().mapBuildResult(completedResult);
                                     if (r != null) { // The blocking job is not a success
                                         build.setResult(r);
                                     }