-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks fail if run on system locked out of public internet. #361
Comments
Suggest another improvement, that the url is shown on the success output: |
I expect your instance is misconfigured somewhere, you need to set the right API url. You can override it on your GitHub app credential I think |
This comment was marked as spam.
This comment was marked as spam.
Thanks for trying to help enravi but I'm assuming that's AI generated and it's incorrect. I've double checked and yes the api url needs setting on the GitHub App credential (in the advanced settings for the credential) github-checks-plugin/src/main/java/io/jenkins/plugins/checks/github/GitHubChecksPublisher.java Lines 77 to 79 in 8d17133
|
Thank you for the clarification. It appears that the GitHub Checks plugin relies on the API URL configured within the GitHub App credential settings for its behavior. |
Jenkins and plugins versions report
If I run my builds with the GitHub Checks plugin installed but on a workstation that is blocked from the public internet, the build quickly fails with the error:
[GitHub Checks] Failed Publishing GitHub checks: java.io.IOException: GitHub Enterprise server (https://api.github.com) with private mode enabled
I definitely don't want our checks published to the public github API. These are proprietary internal builds.
2 questions:
Environment
What Operating System are you using (both controller, and any agents involved in the problem)?
Ubuntu. Everywhere.
Reproduction steps
All I need is the plugin installed, but with an agent that is firewall-blocked.
Consider an iptables approach with a CIDr block to shut off internet access on that agent (while still permitting access to the jenkins controller).
Expected Results
I expect it to fail. Or frankly, I expect to be able to assign a GitHub URL of my internal server. Maybe have the server implied based on my scm configuration of the build, and no error happens.
Actual Results
[GitHub Checks] Failed Publishing GitHub checks: java.io.IOException: GitHub Enterprise server (https://api.github.com) with private mode enabled
Anything else?
There needs to be an input parameter. Publishing to the public website is a huge leak of proprietary information. Is it really doing this??
The text was updated successfully, but these errors were encountered: