Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverarts not displayed in special configuration (https reverse proxy, docker environment) #140

Open
CDaxi opened this issue May 2, 2023 · 1 comment

Comments

@CDaxi
Copy link

CDaxi commented May 2, 2023

Hello,

my setup:

  • Mopidy and Jennyfin are running in the same docker network behind a traefik reverse proxy.
  • Both services will get their public domain and https connection.

In this case, I am not able to get the coverarts displayed.

Tried hostname configurations:

  • [public hostname]:443 - Connection error on backend side
  • [internal hostname]:8096 - Connection an backend side is possible, but frontend will have the wrong url
  • [public hostname]:8096 - Even if the jellyfin docker container has 8096 exposed, at the browser it will use https protocol and no images can be displayed because using https on a http port.

As seen in

def get_image(self, item_id):
, the self.hostname is used in this case.

Ideal for my use case would be if I can define an internal hostname (docker hostname) to fetch the data and a public hostname (using at frontends) to display the coverart.

e.g.:

changing this code:

    def get_image(self, item_id):
        url = f'{self.hostname}/Items/{item_id}/Images/Primary'
        # Verify if image exists instead of returning bad URLs
        image = self.http.head(item_id, url)
        if image:
            return models.Image(
                uri=url,
            )
        else:
            return []

into something like:

    def get_image(self, item_id):
        url = f'{self.public_hostname}/Items/{item_id}/Images/Primary'
        # Verify if image exists instead of returning bad URLs
        image = self.http.head(item_id, url)
        if image:
            return models.Image(
                uri=url,
            )
        else:
            return []

and if public_hostname is not set at the configuration, the same value as for hostname should be used.

Would be great if somebody can add the feature to the extension.
Thanks a lot.

CDaxi

@CDaxi
Copy link
Author

CDaxi commented May 2, 2023

Sorry for interrupting again.
I have seen that there is a port in the ext.conf file which seems never used in the code.
From my point of view having different hostnames for backend and frontend possible would be the best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant