Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth selector highest bandwidth does not account for transcoding to less efficient codec #6449

Open
felix920506 opened this issue Jan 16, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@felix920506
Copy link
Member

Describe The Bug
The bandwidth selector has the highest option capped at the source file bandwidth. However, when transcoding to a less efficient (eg. HEVC -> H264), the highest bandwidth shown is lower than what auto would set it to under ideal network conditions

Steps To Reproduce

  1. Start a video playback
  2. Open the bandwidth selector
  3. See error

Expected Behavior
There should be options that are a good amount higher than the source bandwidth

Logs
N/A

Screenshots
N/A

System (please complete the following information):

  • Platform: all
  • Browser: all
  • Jellyfin Version: 10.10.3

Additional Context
On a video I have, the source bitrate is 2mbps. On auto select with ideal network conditions, transcoding to H264 will have auto set bandwidth of 6.7mbps. However, the selector only has up to 3mbps to choose.

@felix920506 felix920506 added the bug Something isn't working label Jan 16, 2025
@dmitrylyzo
Copy link
Contributor

// Slightly increase reference bitrate for high efficiency codecs when it is not too high
// Ideally we only need to do this for transcoding to h264, but we need extra api request to get that info which is not ideal for this
if (videoCodec && ['hevc', 'av1', 'vp9'].includes(videoCodec) && referenceBitRate <= 20000000) {
referenceBitRate *= 1.5;
}

@felix920506
Copy link
Member Author

I think one way would be to always show options below 10mbps regardless of source bitrate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants