Add Samsung Smart Hub Preview Integration #319
Conversation
…g.com/smarttv/develop/guides/smart-hub-preview/smart-hub-preview.html#Deep-link-Return-Key-Policy) From a detail page within an application, clicking the "Return/Exit" key must display the previous page in the application. https://developer.samsung.com/media/2424/uxguidelines4.png
|
Rewrite the first version, now it works with all emulator. (And I hope with all tv.) |
|
Ci, why closing this PR ? This was a good idea ! |
|
I dont want to close it. |
|
I would maybe switch the layout to continue watching first and next up second but anyhow, when can we expect the merge? This looks to me like a great upgrade to the app. |
|
I still haven't taken the time to review the PR, but after a quick look I believe it could lead to showing unwanted content to children. TV is a sharing device, so we have to take that into consideration. If I understand correctly, it works with the last logged in user. At the moment, we don't perform auto logout (close session) when we exit the app. Thus, when we do, this feature will stop working. |
|
No children in my house so I did not even think about that. As far as I know, some other streaming apps do not log out and show the last watched show/movie, but I understand your concern. |
|
At the moment, it update the smart view 3 - times:
I think all other apps (Netflix, Disney, etc) use the last logged in user data to show up. But we can add some settings when and what to show at the smart view. Any suggestions? |
I have, but they see only public posters what they can see every where else. (Movie theater, on street, at TV) |
|
Jellyfin Android TV has the same feature: |
|
@dmitrylyzo Do I need some modification to this PR? |
|
I would love to have this feature. If this raises concern for child, could it be an option to enable it by conf ? With inactive state by default ? |
There was a problem hiding this comment.
Currently, the PR has bugs, but once fixed, it works. Haven't paid attention to the formatting yet.
We should not load smarthub.js on Tizen 3-. If it can be rewritten for Tizen 3 (or even 2.x), we can unlock it later.
If the preview hub cannot be disabled in Tizen OS (parental control), then we should add an option (disabled by default). We can add clientsettings feature and implement openClientSettings. It would be better to reuse JellyfinWeb UI elements and navigation, but that seems impossible at the moment.
We should also introduce internationalization for Next Up, Continue Watching - less priority, just keep in mind.
|
|
||
| if (primaryImageAspectRatio && uiAspect) { | ||
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | ||
| } |
There was a problem hiding this comment.
primaryImageAspectRatio assignment is missing.
It looks like primaryImageAspectRatio and coverImage can be removed.
| if (primaryImageAspectRatio && uiAspect) { | |
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | |
| } |
|
|
||
| if (primaryImageAspectRatio && uiAspect) { | ||
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | ||
| } |
There was a problem hiding this comment.
primaryImageAspectRatio assignment is missing.
It looks like primaryImageAspectRatio and coverImage can be removed.
| if (primaryImageAspectRatio && uiAspect) { | |
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | |
| } |
|
|
||
| if (primaryImageAspectRatio && uiAspect) { | ||
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | ||
| } |
There was a problem hiding this comment.
primaryImageAspectRatio assignment is missing.
It looks like primaryImageAspectRatio and coverImage can be removed.
| if (primaryImageAspectRatio && uiAspect) { | |
| coverImage = (Math.abs(primaryImageAspectRatio - uiAspect) / uiAspect) <= 0.2; | |
| } |
| function getTileImageUrl(item) { | ||
| item = item.ProgramInfo || item; | ||
|
|
||
| options ={ | ||
| preferThumb: true, | ||
| inheritThumb: true, | ||
| } | ||
|
|
||
| preferThumb = true; |
There was a problem hiding this comment.
I think getTileImageUrl can be simplified since we don't change options.
| exit: async function () { | ||
| try { | ||
| await runSmartViewUpdate(); |
There was a problem hiding this comment.
We can't use async/await on Tizen 3-. I was going to use babel on files.
| if (JSON.parse(actionData).serverid) { | ||
| var serverid = JSON.parse(actionData).serverid; | ||
| var id = JSON.parse(actionData).id; | ||
| var type = JSON.parse(actionData).type; | ||
| var seasonid = JSON.parse(actionData).seasonid; | ||
| var seriesid = JSON.parse(actionData).seriesid; |
There was a problem hiding this comment.
Store JSON.parse(actionData) in a variable.
This pull request introduces support for Samsung Smart Hub Preview integration, enabling Jellifyn users to leverage the native Smart Hub capabilities for better app discoverability and user experience.
Key Features:
- Smart Hub Preview Support:
-Default Configuration:
Testing:
Resolves:
This implementation addresses and resolves issue #318.
Work in Progress:
I am looking for additional testers, especially on newer tizen versions
Decisions are still pending on:
Next Steps:
Feedback on current implementation and configurations.
Suggestions for additional sections or adjustments to the item limits.
More testing on a wider range of devices and scenarios.
Reference:
For more details on Smart Hub Preview capabilities, refer to the Samsung Developer Guide.
Thank you for reviewing this PR! I look forward to feedback and suggestions to enhance this feature further.