Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports notification workspace/didRenameFiles #144

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

dannypsnl
Copy link
Contributor

@dannypsnl dannypsnl commented Feb 4, 2025

resolve #142

@6cdh's suggestion

  • Doc structure contains the URI, therefore, needs to update it
  • scheduler.rkt (I need to look into it)
  • check the new file is a racket file
    • my plan is simply checking newUri is *.rkt

@6cdh
Copy link
Contributor

6cdh commented Feb 5, 2025

Doc struct contains its uri, so we also need to change that (in doc.rkt).

The queries of the old document in queue also need to be handled (maybe just clear them) (in scheduler.rkt).

The new file is probably no longer a racket file, for example, someone create a racket file, but after a second, they realize it should be another language, then they rename it. So we need to check if the new file is a racket file.

The most difficult part is, we probably need to consider other files that depends on the old file.

@dannypsnl
Copy link
Contributor Author

@6cdh About dependency relation between files, I thought this is a big refactoring that should be another PR, and maybe a plan, what do you think?

@6cdh
Copy link
Contributor

6cdh commented Feb 6, 2025

I think so.

Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
@dannypsnl
Copy link
Contributor Author

@6cdh all suggestions are applied.

Signed-off-by: Lîm Tsú-thuàn <[email protected]>
@jeapostrophe jeapostrophe merged commit d1fb56f into jeapostrophe:master Feb 14, 2025
5 checks passed
@jeapostrophe
Copy link
Owner

Thank you!

@dannypsnl dannypsnl deleted the workspace-didRename branch February 14, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support workspace/didRenameFiles notification
3 participants