Respect formatting options #119
Conversation
| (tabSize | ||
| insertSpaces | ||
| trimTrailingWhitespace | ||
| insertFinalNewline | ||
| trimFinalNewlines | ||
| key)) |
There was a problem hiding this comment.
Not sure, but do we always use this style for structure fields? Or JSON requires that?
There was a problem hiding this comment.
It's intended to be same as the names in LSP specification.
Maybe we can have a macro to automatically converts these names to racket name style.
Then we only use the LSP style names in jsexpr->FormattingOptions, and racket style names everywhere else.
There was a problem hiding this comment.
It would be great if that is possible
There was a problem hiding this comment.
What about FormattingOptions and other top level structs? Their name are also inconsistent with Racket style.
There was a problem hiding this comment.
Same, but I think maybe let's have another PR for these changes.
There was a problem hiding this comment.
ok. I'm going to rename these fields.
|
Oh, and as a personal opinion, maybe all |
ok |
|
The automatic renaming is in progress though. There are some difficulties. It could be in another PR. |
I also rewrote some formatting helper functions. It should fix #112