Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix on-type-formatting to make it only format current sexp #114

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix on-type-formatting to make it only format current sexp #114

merged 1 commit into from
Jul 17, 2023

Conversation

6cdh
Copy link
Contributor

@6cdh 6cdh commented Jul 17, 2023 •
edited
Loading

It only formats current sexp now.
It should close #111

@6cdh
fix on-type-formatting
27c8310 
it only formats current sexp now
jryans
jryans approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this! 😄

I can confirm it does appear to fix #111.

@jeapostrophe jeapostrophe merged commit 36d498b into jeapostrophe:master Jul 17, 2023
@jryans jryans mentioned this pull request Jul 18, 2023
Closed
@6cdh 6cdh deleted the fix-on-type-formatting branch August 11, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

@dannypsnl dannypsnl dannypsnl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close paren on type formatting reformats whole document instead of current expression
4 participants
@6cdh @jryans @dannypsnl @jeapostrophe