Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use end-of-file as fallback position for exceptions #104

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Use end-of-file as fallback position for exceptions #104

merged 1 commit into from
Apr 7, 2023

Conversation

jryans
Copy link
Contributor

@jryans jryans commented Apr 7, 2023

Some reader exceptions do not have position information. This uses end-of-file as a reasonable guess, so we can at least highlight some part of the file. Handing this case resolves a langserver contract error.

Fixes #102

@jryans
Use end-of-file as fallback position for exceptions
550378f 
Some reader exceptions do not have position information. This uses end-of-file
as a reasonable guess, so we can at least highlight some part of the file.
Handing this case resolves a langserver contract error.

Fixes jeapostrophe#102
jeapostrophe
jeapostrophe approved these changes Apr 7, 2023
View reviewed changes
Copy link
Owner

@jeapostrophe jeapostrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jeapostrophe jeapostrophe merged commit 570b195 into jeapostrophe:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeapostrophe jeapostrophe jeapostrophe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A #; without something to comment out yields an unrecoverable error
2 participants
@jryans @jeapostrophe