notes.md

Tasks completed:

• Fakers for nullable columns that have foreign keys are currently always generating a non-null value, but sometimes they should fake a null!

• When generating a model to test uniqueness, we should:

  • use the full_model state
  • not generate custom values for columns with foreign keys (let the factory generate the necessary models for us)

• On factories, the full_model state should generate foreign models also in the full_model state

• Column fakers for types other than string or text should not use custom faker methods, but always the one for that type

• In the migration generator, foreign key columns cannot have a default value

  • this should be an error when reading the database.

• On factories that need to generate a model on a unique column, there is no need to specify the unique identifier, as the value in the column will always be unique because we are already creating and persisting the child model.

• Primary keys that span multiple columns should be an error when reading the database

• Do not create views for pivot tables (the problem was that we had a wrong definition of pivot and were generating pivots with soft deletes.)

• Generated pivot tables must not have unique/nullable modifiers.

• Improve the way to generate migrations and to run the autocrud commands in the testing environment

• Fix model not being created in the assertFields method when the only UNIQUE columns are foreign keys

• On stub replacement, see if we can replace with a multi-line string, which must necessarily be correctly indented

• Columns with foreign keys should be dropdown boxes in the create/edit views

• All tables must have a primary key

• On models, many-to-many relationships are not selecting the correct ids on pivot tables that do not follow the standard Laravel convention

• Pivot tables should mean that one of the models has a dropdown for the other model

  • This is computed as such: the first column in the pivot corresponds to the model that shows the dropdown (think role_user with columns user_id and role_id: in this case, it is the user that specifies the roles they have)

• Test APIs on the generated test classes

• When asserting fields, if the model has a unique constraint on a boolean column, the method beginAssertFields must explicitly use the boolean value false associated with that column since the model created to check for uniqueness will already have the value true.

  • Solved by disallowing uniqueness on boolean columns

• Requests with time columns containing the value '25:00:00' are somehow being accepted. Why?

• Words like "scissors" are tripping up the singular and plural conventions. (the route parameter is "scissors", but the parameter name in the controller is "scissor" for some reason...)

  • Solved by not generating table names from nouns whose singular ends in s (sort of...)

Tasks to complete:

Wish-list (non necessary but good to have):

• On models that have no specific need for the full_model (it still needs to exist!), simplify the state definition.

• On generated migrations, do not allow "weird" relationships. For example, table A, column X refers to id of table B, and then there is a pivot for tables A and B...

• Detect weird schemata, and warn the user that unexpected results may be encountered. This includes, at least:

  • columns whose name is also a foreign key relationship

• On generated migrations, date-like columns should sometimes have a default value other than CURRENT_TIMESTAMP

• Allow assertField to test multiple fields simultaneously. This can potentially be used to test uniqueness of multiple columns or (if I'm brave enough) to test multiple-column foreign keys!

• Speed up the tests

  • This is not done (really! Some tests take more than 20 seconds... :|), but the scaffolding to easily detect long tests has been set in place.

Configuration options:

• Allow the user to specify the plural and singular forms of words, if they want

• Fix for Laravel 8 (factories have been refactored and should be handled here)

• Allow users to specify the actual generator to run for each command (defaults to the ones being currently used), as well as to simply change the stub to use but to keep the generator.