Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace certain icons in Toolbar with simpler ones #349

Open
tassadarius opened this issue Jan 26, 2021 · 1 comment
Open

Replace certain icons in Toolbar with simpler ones #349

tassadarius opened this issue Jan 26, 2021 · 1 comment

Comments

@tassadarius
Copy link
Collaborator

Proposal

In my opinion the icons for the keystore and console are overloaded and not clear immediately.

Current status

image

Proposal

I would opt for simpler, more common symbols like this for keystore:

keys

https://www.flaticon.com/free-icon/keys_2825662#


or this for console

command-window

https://www.flaticon.com/free-icon/command-window_656

@grthor
Copy link
Member

grthor commented Jan 27, 2021

With the icon for the keystore, I'm concerned that it won't be recognizable at 16x16 pixel size.

I like the icon for the console. It clearly shows that there is a console behind it.

Attributing Icons is no problem. We do this already with the restart Icon. In our about-Page the attributions are listet:
https://github.com/jcryptool/core/blob/e42753e4a69cfc31b3b1e6bc92afaa7773a9f3cb/org.jcryptool.core/OSGI-INF/l10n/bundle.properties#L72
Neustart-Ikon by Google from flaticon.com / CC BY 3.0

We have to make sure that we don't use black icons. You can't see them in dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants