Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for easier experimentation #1

Open
jcreinhold opened this issue Oct 3, 2021 · 4 comments
Open

Refactor for easier experimentation #1

jcreinhold opened this issue Oct 3, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@jcreinhold
Copy link
Owner

The current state of the code is bad. It's hard to understand and essentially hard-coded for the experiments I ran for the paper. But the core functionality could be broken out into class/module which could be extended for other experiments and other types of data.

@jcreinhold jcreinhold added the enhancement New feature or request label Oct 3, 2021
@jcreinhold jcreinhold self-assigned this Oct 3, 2021
@HarshaSatyavardhan
Copy link

Hey is this still progress. I was trying to extend to different datasets but finding hard to understand the code

@jcreinhold
Copy link
Owner Author

I don't have plans to refactor this code anytime soon.

@jcreinhold
Copy link
Owner Author

jcreinhold commented Jun 23, 2023

In the code's current state, you'd need to write a new module/model which is located in experiment to extend this framework to other datasets/diseases. Easier said than done, but it's not impossible. Doing so would likely require fairly deep knowledge of Pyro internals, if I recall correctly. And I'm not even sure if this framework is compatible with the current implementation of Pyro/PyTorch.

@HarshaSatyavardhan
Copy link

Is there an alternative to this ? As I am new to pyro, are there any implementations of this or deepscm paper with proper documentation available that are compatible with the latest version of Pyro, to the best of your knowledge ?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants