Fix interface handling to support renaming across interface files

[mrvicadai]

Hi there, I'm using reason-langauge-server along with vscode and so far it's been a solid experience. When using symbol renaming (F2), it seems to only work in the scope of a single file / module. It would be so nice if renaming could be propagated to the entire project.

I know this feature isn't easy, so just want to put in a request to keep on the backlog : )

[jaredly]

Could you detail the situations where it doesn't work? This feature is supported, but might have some bugs :)

[mrvicadai]

@jaredly Okay found it! Here's a quick SSCCE

// foo.re

let ask = (question: string) => Js.log(question);
let inquire = (question: string) => Js.log(inquire);

// foo.rei
// do not expose "ask" function.
let inquire: string => ();

// bar.re

Foo.ask("Howdy");
//  ^ rename the "ask" token

Now when I try to rename the ask symbol in foo.re (the source), the original method in foo.re is indeed changed; however the ask reference in bar.re is not changed.

Also, when I remove the .rei file, the rename feature works -- so I'm guessing it's a bug when taking the interface definition into consideration.

[jaredly]

hmmm if foo.rei doesn't expose ask, then bar.re shouldn't be able to access it at all 🤔 does that code even compile?

[mrvicadai]

My bad, I've got it wrong for which module the .rei file is created for. Here's the updated example:

/* foo.re */

let ask = (question: string) => Js.log(question);
let inquire = (question: string) => Js.log(question);

/* bar.re */

let greet1 = () => Foo.ask("Howdy");
/*  ^ rename the "ask" symbol */

let greet2 = () => Foo.inquire("Howdy");

/* bar.rei */
/* do not expose "greet1" function. */
let greet2: () => ();

[jaredly]

ah yes, I definitely need better support for interfaces

[jaredly]

Partially fixed -- there's still a bug if you have bucklescript's namespacing turned on...