Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bsb to be run from globally installed bs-platform #393

Open
jonni-larjomaa opened this issue Feb 7, 2020 · 6 comments
Open

allow bsb to be run from globally installed bs-platform #393

jonni-larjomaa opened this issue Feb 7, 2020 · 6 comments

Comments

@jonni-larjomaa
Copy link

bs-platform related binaries are by default expected to reside in the projects node_modules folder. allow changing this value to something else for example globally installed bs-platform support.

@jaredly
Copy link
Owner

jaredly commented Apr 11, 2020

Does globally installed bs-platform work these days? It never actually was able to build for me, so I haven't bothered supporting it.

@cristianoc
Copy link
Contributor

cristianoc commented Apr 11, 2020

It's definitely not recommended. OK when a new version of bs comes out every year or so, at most, which is not true at the moment.
Like for the build, these days each project specifies their own version of bs.
And doing differently for editor support can make things go out of sync.

@jonni-larjomaa
Copy link
Author

yes globally installed bsb works for me atleast? on mac os x catalina and installed with npm i -g bs-platform. The problem with project specific approach is tied to running dev env inside docker-containers, the binaries are not compatible between linux / darwin envs. and running vscode IDE natively in mac and the whole other environment (with project mounted volumes) inside docker. the ide cannot run the project specific bsb as it is build with linux kernel. as for globally installed would be build for mac. and also for the reason that ides would need project specific stuff running in order to help with compiling / type hinting etc. is bad design IMHO.

@jonni-larjomaa
Copy link
Author

Just wondering why setting the bsb binary path to something else than default would harm anyone? by a configuration value.

@cristianoc
Copy link
Contributor

@jonni-larjomaa leaving the IDE aside for a second. Where does the build take place, inside the linux container or outside on the Mac?

@jonni-larjomaa
Copy link
Author

jonni-larjomaa commented Apr 14, 2020

@cristianoc Basically linux-container does not need anything else than compiled js, so build could happen in mac, but. here is the but, npm install is run inside linux-container this is because all depencies that do dynamic compilation of binary functions needs to happen inside linux-container. So how this is accomplished is basically mounting the project folder inside docker (at local machines, production containers are build as self-containing containers ofcourse). and i don't want to go to the extremes of "exclude bs-platform and depencies from mount" and then separetly running npm install inside docker and on mac (which would still not solve the problem of the IDE!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants