Hover on a react prop doesn't always point to the right type

[bsansouci]

Here's a screenshot of what I mean. I'm hovering over paddingBottom inside the call to ReactDOMRe.Style.make and the highlight is wrong and the type is also wrong.

[MoOx]

Same kind of problem

Here I am trying to hover my c variable and the plugin seems totally lost track of what I want to do.
What triggered me is that an entire jsx block is being highlighted, and it shouldn't be the case.

In other "non-jsx" places, this it totally working as expected. Only the thing I have the cursor on is highlighted

I recently started to become annoyed by this when doing a screencast (lol) I was like "now we can see what type is this var" and the effect was no good 😂

Every time I want to tackle something in this repo, I feel so dump. I don't even know how to look at.
Can somebody point me in the right direction to start working on this?

@jaredly? or maybe @anmonteiro - sorry I just looked at top 2 contributors haha

[MoOx]

I discussed about this with @bloodyowl and he told me that maybe the jsx ppx was the culprit because of some code locations being somehow not correct. Poke @rickyvetter

This is also causing lots of various issue, like cmd+click being broken (always bringing you to react.createElement reason definition) & autocomplete completely lost & broken too.

[cristianoc]

This is likely a question for the JSX ppx. @rickyvetter

[MoOx]

It seems there is a know issue on react-react reasonml/reason-react#429

[rickyvetter]

Hey folks. Most recent version of BuckleScript (I believe >7.1.1) has a bunch of PPX changes that will make this better. There are still a couple known problems that I'm working on, if you have specific cases to report please make an issue on https://github.com/reasonml/reason-react and include BuckleScript version and ReasonReact version. This will help greatly in getting a repro and being able to address.