Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goto defintion goes to module only not function or binding #243

Open
yunti opened this issue Feb 7, 2019 · 5 comments
Open

Goto defintion goes to module only not function or binding #243

yunti opened this issue Feb 7, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@yunti
Copy link

yunti commented Feb 7, 2019

In a current project when using reprocessing, the plugin fails to go to the specific module function eg Draw.fill(..) instead just goes to the Draw module.
This is also the same in inbuilt modules

eg Array.make_matrix only goes to array.mli

(Sorry if this is a known limitation rather than a bug. )

Repo here
https://github.com/yunti/reason-twenty48

@yunti
Copy link
Author

yunti commented Feb 7, 2019

Hmmm now I'm getting a 'You need to run bsb first ...' pop up.

Running bsb in terminal .... I get a no bs-platform is not found error (it's globally installed with yarn)

As reprocessing uses bsb-native, bsb-platform isn't in the dev dependencies

image

@yunti
Copy link
Author

yunti commented Feb 7, 2019

Trying the default reprocessing example repo
(https://github.com/bsansouci/reprocessing-example/tree/2048)
I can also only go to module level definitions not down to bindings.
So possibly this is a feature request rather than a bug :)

@jaredly
Copy link
Owner

jaredly commented Feb 10, 2019

Hmmm it should be able to jump you directly to the binding 🤔

@jaredly jaredly added the bug Something isn't working label Feb 10, 2019
@yunti
Copy link
Author

yunti commented Feb 11, 2019

Thanks for confirming it looks like a bug. Hopefully the default reprocessing repo I linked will have enough to replicate and highlight where the issue is. I need to learn some more before I can dive in and sort these out directly.

@yunti
Copy link
Author

yunti commented Feb 15, 2019

hmm it's now worse for some reason I can't goto definition of a module or a module binding whether a standard lib or a third party package.

I did start with the reprocessing-example github and added bsb-platform to the dev dependencies to see if that would help - but unfortunately not.
repo here
https://github.com/yunti/twentyfortyeight

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants