-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error building esy project when in a monorepo with a bucklescript frontend #193
Comments
It's worth noting that if I open VS Code in the backend project only, it works correctly. |
Oh, this is with version 1.3.0 of the VS Code extension. |
excellent :) |
Err. Did you mean to close this @jaredly ? |
oh wait, sorry! I somehow read "this is fixed with version 1.3.0" |
Oops! No, new issue with 1.3.0. 1.2.6 didn't even pick up my project correctly at all, so progress! |
Update for 1.4.0. Looks like the same issues are still around, it's just that there's now a different error message: /node_modules/.lsp/debug.log
It looks like RLS is still creating a phantom |
I'm getting this too while playing around with this project https://github.com/anmonteiro/reason-graphql-fullstack which has a similar structure. @mscharley I couldn't even get it to work by opening VS Code in the backend folder (specifically this folder https://github.com/anmonteiro/reason-graphql-fullstack/tree/master/src/server) -- does that still work for you with 1.4.0? I couldn't get your symlink approach to work that you mentioned in #162 either. |
The backend folder is working directly as of 1.4.0. The symlink is no longer necessary either, RLS picks up esy and dune and just works, the only issue I'm having is the apparently folder changing issue when the esy project isn't in the project root. |
@nielmond that project is actually a nice example where RLS works. However I don't think the way to get it working is documented yet. That would be a great first contribution if you'd like to do it. Here's an explanation: Basically |
@anmonteiro Thanks for the suggestion. Opening with
for both main.re and schema.re. Looking in .lsp/debug.log on startup, it seemed to be going OK and then this happened:
|
Hello! I know this is an old issue, but I solved the You can clean it by running:
And then I just re-ran |
My project structure is as follows:
I have a workspace setup in VSCode with three top-level folders,
/
,/packages/backend
and/packages/frontend
./node_modules/.lsp/debug.log
/packages/backend/node_modules/.lsp
Doesn't exist.
The log files look correct, but I'm noticing that there is an _esy folder that's popped up in the root of my project now. It could be that RLS isn't changing folder to the project root before executing the esy command.
The frontend project, which is BuckleScript + NPM works perfectly.
The text was updated successfully, but these errors were encountered: