Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BetterErrors #144

Open
IwanKaramazow opened this issue Sep 30, 2018 · 7 comments
Open

Use BetterErrors #144

IwanKaramazow opened this issue Sep 30, 2018 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@IwanKaramazow
Copy link
Contributor

image

It occured to me that this warning with with has a reference to Ocaml. The terminal output gives
image

Is there a way to print the reason super errors instead of the stock ocaml ones?
IwanKaramazow referenced this issue in kutyel/reason-catstagram Sep 30, 2018
Add comments! 🗯️
72a6c96
@thangngoc89
Copy link
Contributor

I thought this was fixed awhile ago. Did you try latest plugin?

@IwanKaramazow
Copy link
Contributor Author

Oh, this is probably not released on the vscode store right?

@jaredly
Copy link
Owner

jaredly commented Oct 3, 2018

the with thing is maybe a bettererrors difference, which I don't currently have enabled

@jaredly
Copy link
Owner

jaredly commented Oct 3, 2018

the source code is output in reason syntax though

@IwanKaramazow
Copy link
Contributor Author

Is it possible to hook into bettererrors?

@jaredly
Copy link
Owner

jaredly commented Oct 3, 2018

totally could, would just require some postprocessing of the error message to strip out the source code.

@jaredly jaredly changed the title Warnings are ocaml flavoured in the language server Use BetterErrors Oct 3, 2018
@jaredly jaredly added enhancement New feature or request help wanted Extra attention is needed labels Oct 3, 2018
@jaredly
Copy link
Owner

jaredly commented Oct 3, 2018

Steps needed:

  • detect the location of betterErrors when setting up a package (check out how we do this for refmt here)
  • call bettererrors with the error output here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaredly @thangngoc89 @IwanKaramazow