-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbound module when using Dune + Esy on a Project #105
Comments
Hmm that's the module name that dune creates to wrap a library (name ++ "__") |
Oh! Thats cool to know 😁. Do you know why this might be happening? It seems to break everything else, autocomplete, types on hover, etc. |
@kennetpostigo what version of ocaml are you using? RLS doesn't work with newer OCaml version (yet) |
@thangngoc89 thats probably it. |
Is this still an issue? |
@jaredly Still have issues with
|
@jaredly I'll check on a native project later tonight to confirm |
There are a couple of things that seem to be issues for the I tested this on the latest released version of RLS (1.2.4). |
In my hello world project
Mine is now |
I'm able to reproduce this every time by using a dune version after 1.6. So, in the |
@quartz55 thanks for the comment. I was able to downgrade to dune 1.6 and things are working. Nice temporary workaround. |
So I think this boils down to needing to use the .merlin file more directly -- I'm trying to be too fancy with figuring out where source files & artifacts live, and that's messing things up when dune decides to put them somewhere else. |
Here's a repo that reproduces the issue: donut/reason-vscode-unbound-module__ Just run I tried downgrading dune and OCaml to no avail. |
Yeah so I've completely overhauled the way that dune file artifacts are found in the latest release https://github.com/jaredly/reason-language-server/releases/tag/1.6.0 behind a flag |
@jaredly I'm having the same problem, using the new flag solved it for me. Thanks! EDIT: spoke too soon, I think I had an old version of dune installed but now that everything is updated I'm still getting the error EDIt 2: And now it works again after restarting vscode. Something is flaky, but for now it works :) |
@jaredly That flag worked for the reproduction repo I linked to. Thank you! |
The reaosn-vscode extensions issues was resolved. issue jaredly/reason-language-server#105 (comment)
@jaredly the flag is working, but I didn't understood something, it will be the default in the future, or it will be removed? |
I'm testing out the extension from the marketplace for the first time and I'm seeing this message in the problems panel:
I've compiled the project and ran it a few times to make sure it wasn't in issue in my code. The module it mentions there is similar to a module in my code
Std
but without the trailing__
. Not sure what may be causing this.Debug Log
The text was updated successfully, but these errors were encountered: