Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things to do #9

Open
jaredlll08 opened this issue Oct 1, 2020 · 0 comments
Open

Things to do #9

jaredlll08 opened this issue Oct 1, 2020 · 0 comments

Comments

@jaredlll08
Copy link
Owner

Seeing as it is Hacktoberfest and Modtoberfest, here is a list of things that people could PR.

  • Code optimisation

In the coming days I'm going to add a config system to let people choose different algorithms used to colour each thing (Grass, Water and Foliage), so submitting new algorithms when I've done that would be really cool
@jaredlll08 jaredlll08 pinned this issue Oct 1, 2020
PaintNinja added a commit to PaintNinja/Ambient-Environment that referenced this issue Oct 23, 2020
@PaintNinja
Update Forge base, populate mods.toml with more info, minor perf opti…
021f6b5 
…misations

The optimisations are possibly relevent to jaredlll08#9, albeit very minor.

Changes:
- Update Forge base to the recommended version for 1.16.3
- Add GitHub issues and CurseForge project links to mods.toml
- Declare variables and arguments as immutable where appropriate
- Multi-assignment of variables, avoiding some repetition
@PaintNinja PaintNinja mentioned this issue Oct 23, 2020
Merged
jaredlll08 pushed a commit that referenced this issue Oct 24, 2020
@PaintNinja
Update Forge base, populate mods.toml with more info, minor perf opti…
da77483 
…misations (#11)

* Update Forge base, populate mods.toml with more info, minor perf optimisations

The optimisations are possibly relevent to #9, albeit very minor.

Changes:
- Update Forge base to the recommended version for 1.16.3
- Add GitHub issues and CurseForge project links to mods.toml
- Declare variables and arguments as immutable where appropriate
- Multi-assignment of variables, avoiding some repetition

* Implement requested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredlll08