added extract_replace() #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
force-pushed
the
jaykay9999-patch-1
branch
2 times, most recently
from
4bf0eda to
e01ab1c
Compare
jaraco
requested changes
Apr 6, 2022
Comment on lines
+3895
to
+3901
| #this function takes a string and returns an array with indexes of every first and last digit in the sentence. | ||
| #example : test_array = find_num_index("In 2019, mark saved $15 thousand, for a total savings of 54 thousand over eight years." ) | ||
| #print(test_array) | ||
| #output : [3, 6, 21, 22, 57, 58] | ||
| # 3 and 6 are the indexes of 2 and 9 of "2019" | ||
| # 21 and 22 are the indexes of 1 and 5 of "15" | ||
| #and it keeps going |
There was a problem hiding this comment.
Documentation for a function should be implemented as a docstring.
| # 21 and 22 are the indexes of 1 and 5 of "15" | ||
| #and it keeps going | ||
|
|
||
| def find_num_index(entry_string): |
There was a problem hiding this comment.
This "function" is implemented as a method of "engine", but it's not marked as a staticmethod nor does it take "self" as the first parameter. Do you want an instance method or function? How have you invoked this?
| # 21 and 22 are the indexes of 1 and 5 of "15" | ||
| #and it keeps going | ||
|
|
||
| def find_num_index(entry_string): |
There was a problem hiding this comment.
Do you expect this function to be public or an internal implementation detail?
Comment on lines
+3937
to
+3941
| # extract_replace function takes a sentence with numbers to return a sentence with all its numbers to words. | ||
| #this function uses both number_to_words function and find_num_index function | ||
| #example : test_sentence = extract_replace("In 2019, mark saved $15 thousand, for a total savings of 54 thousand over eight years." ) | ||
| #print(test_sentence) | ||
| #output : In two thousand and nineteen, mark saved $fifteen thousand, for a total savings of fifty-four thousand over eight years. |
|
Feel free to re-engage on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i added two functions : extract_replace() that takes a sentence string and returns the same string with all the number changed to words.
second function is find_num_index() which is only used by extract_replace function, it takes a sentence string and returns an array with indexes of every first and last digits of all numbers in a sentence.
If anything has to be changed or fixed to meet the repository governance please let me know :)
Closes #148