-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require test dependencies when building #13
Comments
Currently the inline tests are always built and always end up in the final executable. Is that the issue here? |
Pretty much. I have some tests that require some extra processing, and the extra dependencies are not acceptable for the library under test. |
ppx_inline_test does have an option to drop the tests: |
And I suppose this can be made conditional? Sorry for my jbuilder noobness. |
Not currently. We added a notion of build profiles in the master of dune, so this could be use to do something different depending on which profile is selected. However there is still something missing in order to pass flag conditionally. Since this is a common case, I'm wondering if we can't simply just drop tests when the profile is |
I think disabling the tests in release mode would be great. |
Could you open a ticket on ocaml/dune? |
Right now it seems like if a PPX test mentions a module, the dependency providing that module must be installed when building the tested code.
This should be made unnecessary, so that only building with runtest requires extra dependencies.
The text was updated successfully, but these errors were encountered: