-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from iso639
to iso639-lang
#3140
Comments
iso639
to iso639-lang
to support Python 3.12+iso639
to iso639-lang
I support this. After upgrading to Ubuntu 24 (Python 3.12.3) calibre fails to start: |
You need |
I already have python3-setuptools installed (68.1.2-2ubuntu1), how do you suggest to install iso639 packages? pipx returns an error: |
Set up a python venv for it and install all the deps there I suppose, then
make calibre-web use the venv
…On Mon, Sep 2, 2024, 18:30 Luis Novo ***@***.***> wrote:
You need python-setuptools as a mandatory dependency on 3.12 which might
work around the issue for now, it did for me on Arch Linux.
I already have python3-setuptools installed (68.1.2-2ubuntu1), how do you
suggest to install iso639 packages? pipx returns an error:
No apps associated with package iso-639 or its dependencies
(same for iso-639)
pip no longer installs anything:
error: externally-managed-environment
and apt can't find the package:
E: Unable to locate package python3-iso639
Any help would be greatly appreciated...
—
Reply to this email directly, view it on GitHub
<#3140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMQXEQGSO4Y2JWMKLI63Q3ZUSHD5AVCNFSM6AAAAABNO7YUSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGA3TINRQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks for your suggestion. Unfortunately, your original comment about incompatibilty between python 3.12 and iso639 still stands. Even if I could install the package with pipx inside a venv, it wouldn't work... I'll keep trying, anyway, will let you know if there is any advance in the matter. |
I did get it working on Arch in the end as per the comments above, which uses 3.12, but it newly requires setuptools to be available. |
The newest nightly version already has a fix for it (hopefully): Pycountry is already supported as there had been problems with debian (I guess?) in the past. For now the workaround is delete the line iso639 in the requeirements.txt file and install pycountry |
Yes, that worked :-) Thanks a lot |
Thanks for the workaround. This reminds me of the cryptography requirement issue when installing Calibre-Web from source. Would it be OK if a step is added in the Manual Installation to recommend users to run |
@deldesir
@OzzieIsaacs |
👍 @C0rn3j for pointing out the removal of setuptools preinstall in venv. I understand that adding it to requirements.txt is part of the temporary workaround, right? |
No, that's THE workaround, or rather the fix for the current build system. The library ( It still remains unmaintained and needs to be migrated away from when possible, but Calibre-web will work again as is with the fix. That said, if |
On Windows, I am still getting the error. Do you know what I can do? - C:\calibre>calibreweb.exe I have requirements.txt installed - C:\calibre>python3.exe -m pip install -r _internal\requirements.txt |
In the calibre-Web folder should be a file requirements.txt, please open it and delete the iso-639 line, it should start then, I’ll check it |
@ravibaskaran Sounds like you are attempting to use an old version of Calibre-web. Btw putting the entire text in a tripple backtick ``` textblock would probably be better. |
The exe version has everything it needs included, so installing anything else is not helping, I‘ll check what’s wrong |
iso639
won't work with Python 3.12,maintainer said this February that they are not actively using or developing the library anymore, and that a future version would still need to support Python back to 2.6.iso639-lang exist which supports 3.7-3.12, which seems perfect for the project as currently minimum marked version for calibre-web is 3.7.
PR in another project that did the same migration can be found here.
EDIT: This may actually not be strictly needed for 3.12 support, but the project being basically dead is not a good outlook for future versions.
The text was updated successfully, but these errors were encountered: