Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commiting dist file #27

Closed
KonradLinkowski opened this issue Sep 8, 2020 · 1 comment
Closed

Commiting dist file #27

KonradLinkowski opened this issue Sep 8, 2020 · 1 comment

Comments

@KonradLinkowski
Copy link

Hello,

I was looking through the code and it seems that you are using deprecated package:: @zeit/ncc.
It could be replaced with @vercel/ncc or even removed at all, because there is just one .js file. Commiting dist folder to the repository seems to be not the greatest idea anyway.
I can code the changes if you want to.

Have a nice day :)
@jamesgeorge007
Copy link
Owner

it seems that you are using deprecated package:: @zeit/ncc. It could be replaced with @vercel/ncc

Thanks for pointing out, #30 handles it.

Commiting dist folder to the repository seems to be not the greatest idea anyway

GitHub expects that you to include any package dependencies required to run the JavaScript code. More information here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesgeorge007 @KonradLinkowski