Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientEntraceFactory. GetClientEntrance incorrect #1

Open
jaksonlin opened this issue Apr 24, 2019 · 1 comment
Open

ClientEntraceFactory. GetClientEntrance incorrect #1

jaksonlin opened this issue Apr 24, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@jaksonlin
Copy link
Owner

jaksonlin commented Apr 24, 2019

in ClientEntraceFactory. GetClientEntrance
it new the ClientEntrace for each call, which is incorrect because the container will be created multiple times.

Fix is to use signleton to hold the ClientEntrance, but we need to find a reliable way for user to inject other ITokenProvider later.

For now if the user uses the IClientEntrance created by the first time calling of GetClientEntrance all the way down - it should be fine. (call it only once and provide the ITokenProvider containing all things user needs)
Otherwise it will break the singletons maintained by the container.

These singletons are defined in FsBaseExecSvc/Registry/RPCClientRegistry.cs

@jaksonlin
Copy link
Owner Author

one way to do is to use: https://jasperfx.github.io/lamar/documentation/ioc/registration/changing-configuration-at-runtime/

but they say - dont' do this. Will try and see what happen

@jaksonlin jaksonlin added the enhancement New feature or request label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant