Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double quotes wrapping $CAFullname #220

Open
systeminsecure opened this issue Jan 10, 2025 · 7 comments · Fixed by #222
Open

Add double quotes wrapping $CAFullname #220

systeminsecure opened this issue Jan 10, 2025 · 7 comments · Fixed by #222
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@systeminsecure
Copy link

Describe the Bug
Suggested fix output for ESC11 does not run correctly when CAFullName has spaces.

Steps To Reproduce
Copy suggested fix code from output after tool has run, run suggested code on CA in either cmd prompt or powershell, receive error "CertUtil: Too many arguments".

Expected Behavior
The command executes successfully.

Environment

  • Locksmith Version: 2025.1.1
  • OS: Windows 2022
  • PowerShell Version: Windows PowerShell 5.1
  • PowerShell Host: PowerShell ISE

Additional Context

This can be fixed by changing lines 369 and 378 to the following:
certutil -config "$($CAFullname)" -setreg CA\InterfaceFlags +IF_ENFORCEENCRYPTICERTREQUEST

Great tool - Thanks!!

@systeminsecure systeminsecure added the bug Something isn't working label Jan 10, 2025
@jakehildreth jakehildreth added the good first issue Good for newcomers label Jan 10, 2025
@systeminsecure
Copy link
Author

Looks like the formatting broke what I entered.

Should be a backtick, double quote, $($CAFullName), backtick, double quote

@jakehildreth
Copy link
Owner

Great catch! Do you want to submit the PR?

@systeminsecure
Copy link
Author

I don't have this broken out into a fork or branch anywhere. I'll get around to it sometime, but for now I'm a little pressed for time.

@jakehildreth
Copy link
Owner

Not a problem. I'll get it handled probably tomorrow morning then. Thanks!

@jakehildreth jakehildreth self-assigned this Jan 10, 2025
@jakehildreth jakehildreth linked a pull request Jan 10, 2025 that will close this issue
SamErde added a commit that referenced this issue Jan 10, 2025
@jakehildreth
Copy link
Owner

@systeminsecure, this has been merged into the testing branch. If you don't mind testing, I don't mind saying thanks!

@systeminsecure
Copy link
Author

Can confirm the fix works.

@jakehildreth
Copy link
Owner

Excellent. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants