-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finding Flowcharts To Feed Severity Ratings #121
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
jscpd | yes | 16 | 2.02s | ||
editorconfig-checker | 42 | 1 | 0.46s | ||
markdownlint | 9 | 22 | 1.37s | ||
markdown-link-check | 9 | 9 | 2.13s | ||
✅ MARKDOWN | markdown-table-formatter | 9 | 0 | 0.28s | |
powershell | 25 | 17 | 38.03s | ||
✅ POWERSHELL | powershell_formatter | 25 | 0 | 24.92s | |
checkov | yes | 1 | 12.95s | ||
✅ REPOSITORY | gitleaks | yes | no | 0.44s | |
✅ REPOSITORY | git_diff | yes | no | 0.01s | |
✅ REPOSITORY | grype | yes | no | 13.43s | |
✅ REPOSITORY | secretlint | yes | no | 0.94s | |
✅ REPOSITORY | trivy | yes | no | 5.14s | |
✅ REPOSITORY | trivy-sbom | yes | no | 1.47s | |
✅ REPOSITORY | trufflehog | yes | no | 7.19s | |
cspell | 43 | 287 | 9.46s |
See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true
in mega-linter.yml to validate all sources, not only the diff
Nice! The docs and visuals should help a lot. I haven't had a chance to review the actual flow for each severity evaluation yet, but the rest looks great. One question: would it be worth creating a future-proof 'Docs' folder that contains 'Flowcharts' as well as any future documentation that is created (or generated with platyPS)? |
Really nice work. I think these flowcharts are a great addition to the project! Question: Do we think having a key or a glossary to explain some of these terms may be useful to folks not super familiar with these concepts? Or maybe just clarify what we mean? Such as BuiltIn/PKI Admin, AD Admin. It may be utterly trivial, just thinking edge cases with terminology. |
Yeah, I think a glossary is a great idea now that we have a Docs folder! :D |
In order to build out automated severity ratings, we need to know what the severities are first! Then we can build code to match. These should help.