Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ochaloup
Copy link

fixes #191

@jta-bot
Copy link
Contributor

jta-bot commented Apr 22, 2021

Can one of the admins verify this patch?

@tomjenkinson
Copy link
Contributor

OK to test

@tomjenkinson
Copy link
Contributor

@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed?

@ochaloup ochaloup force-pushed the unchecked-transaction-instead-of-runtime branch 2 times, most recently from d32e34d to 05e4197 Compare April 22, 2021 19:30
@tomjenkinson
Copy link
Contributor

@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change?

The test would be to:

  • Verify that an @Transactional annotated bean that throws an java.lang.Error will result in the transaction being marked for rollback?
    *Verify that an @Transactional annotated bean which is declared to rollbackOn SQLException (and not SQLWarning) and that throws an Error in one of the relevant methods does actually cause the transaction to be marked for rollback?

This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional

…ption for rollback for CDI interceptor

Signed-off-by: Ondra Chaloupka <[email protected]>
@ochaloup ochaloup force-pushed the unchecked-transaction-instead-of-runtime branch from 05e4197 to 38ba038 Compare September 17, 2021 13:07
@ochaloup
Copy link
Author

@tomjenkinson sure, I know. I will try to create the tests in TCK.

@tomjenkinson
Copy link
Contributor

retest this please

1 similar comment
@tomjenkinson
Copy link
Contributor

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants