-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#191] using term unchecked exception instead of RuntimeException for rollback for CDI interceptor #192
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
OK to test |
@ochaloup would it result in changes to the TCK? If not, can a TCK test be proposed? |
d32e34d
to
05e4197
Compare
@ochaloup as you may have seen over at https://www.eclipse.org/lists/jta-dev/msg00198.html I have raised the topic with the community. I would ask, should the change was agreed, would you be willing to create a TCK test that can be used to verify implementations are compliant with the change? The test would be to:
This might be the place that the test could be added to should the change be agreed: https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/com/sun/ts/tests/jta/ee/transactional |
…ption for rollback for CDI interceptor Signed-off-by: Ondra Chaloupka <[email protected]>
05e4197
to
38ba038
Compare
@tomjenkinson sure, I know. I will try to create the tests in TCK. |
retest this please |
1 similar comment
retest this please |
fixes #191