Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details in CONTRIBUTING.md specifying conditions for a PR to be merged #100

Open
tomjenkinson opened this issue Jun 10, 2020 · 1 comment

Comments

@tomjenkinson
Copy link
Contributor

Do we want to require a review from a commit author before working on issues that are not in the master branch?

Do we want to disable branch protection on master so a committer can directly merge to master? Do we want to require some kind of notification to jta-dev and a period defined in hours/days?

Any other suggestions?

@tomjenkinson
Copy link
Contributor Author

For future reference, here are some details that @gregw shared on a Jakarta related mailing list related to servlet-api guidelines: https://github.com/eclipse-ee4j/servlet-api/blob/master/CONTRIBUTING.md#project-contribution-guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant