Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of initialization of species and current_time #3

Open
jaideep777 opened this issue Jan 7, 2023 · 1 comment
Open

Fix order of initialization of species and current_time #3

jaideep777 opened this issue Jan 7, 2023 · 1 comment

Comments

@jaideep777
Copy link
Owner

Species initialzation happens before current_time is set. This is not the natural order, as species inital state may depend on time. Ensure that current_time is initialized before species init.
jaideep777 added a commit that referenced this issue Jan 7, 2023
@jaideep777
[feature_save_state] All tests passing. issue #3 raised on github
181cf6c
@jaideep777
Copy link
Owner Author

This is still unresolved because current_time can be set during Solver::initialize() which is done AFTER addSpecies()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaideep777