Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash-update! refactoring should eta reduce when possible #419

Closed
jackfirth opened this issue Nov 24, 2024 · 0 comments · Fixed by #421
Closed

hash-update! refactoring should eta reduce when possible #419

jackfirth opened this issue Nov 24, 2024 · 0 comments · Fixed by #421
Labels
existing lint Issues or pull requests relating to existing lints

Comments

@jackfirth
Copy link
Owner

In racket/drracket#698, Resyntax refactored (hash-set! selected choice (not (hash-ref selected choice))) to (hash-update! selected choice (λ (v) (not v))), but it would have been better to produce (hash-update! selected choice not).
@jackfirth jackfirth added the existing lint Issues or pull requests relating to existing lints label Nov 24, 2024
@jackfirth jackfirth mentioned this issue Nov 24, 2024
Merged
jackfirth added a commit that referenced this issue Nov 24, 2024
@jackfirth
Improve hash-update refactoring
8666e86 
Closes #419.
@jackfirth jackfirth mentioned this issue Nov 24, 2024
Merged
jackfirth added a commit that referenced this issue Nov 24, 2024
@jackfirth
Improve hash-update refactoring (#421)
000c75c 
Closes #419.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
existing lint Issues or pull requests relating to existing lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve hash-update refactoring jackfirth/resyntax
1 participant
@jackfirth