Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance tests #50

Closed
ColeDCrawford opened this issue May 16, 2024 · 2 comments
Closed

Add performance tests #50

ColeDCrawford opened this issue May 16, 2024 · 2 comments
Assignees

Comments

@ColeDCrawford
Copy link
Contributor

PR #36 adds packratting for pyparser to improve performance. I think it would be great to merge in that feature, but also useful to take some benchmarks for before and after. These can be done as part of the CI, though I don't think we necessarily need them to hit specific metrics for the CI to pass.

@aweakley aweakley self-assigned this May 22, 2024
@aweakley aweakley mentioned this issue May 27, 2024
5 tasks
aweakley added a commit that referenced this issue May 27, 2024
aweakley added a commit that referenced this issue May 27, 2024
aweakley added a commit that referenced this issue May 27, 2024
aweakley added a commit that referenced this issue May 27, 2024
aweakley added a commit that referenced this issue May 27, 2024
@aweakley
Copy link
Member

aweakley commented May 27, 2024

The benchmark graphs are appearing here now https://ixc.github.io/python-edtf/dev/bench/ The docs say it's not safe to allow updating your gh-pages on pull-request, so I've excluded PRs which is a bit of a shame. I'll try to break it into two steps.

aweakley added a commit that referenced this issue May 27, 2024
aweakley added a commit that referenced this issue May 27, 2024
@aweakley
Copy link
Member

This does seem to have made quite a difference in some cases:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants