Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parser performance #11

Closed
cogat opened this issue May 22, 2017 · 1 comment
Closed

Improve parser performance #11

cogat opened this issue May 22, 2017 · 1 comment

Comments

@cogat
Copy link
Contributor

cogat commented May 22, 2017

The parser seems to take a while to compile, and another while to parse dates, especially sets of multiple dates.

The EDTF grammar is geared towards exactness rather than speed, meaning that there are strict definitions of numbers which can be used in months, etc.

There might be ways of relaxing the lexical definitions in order to improve parse speed, and then perhaps validating actual values using something simpler after parse time.
@jmurty jmurty mentioned this issue May 29, 2017
Open
jmurty added a commit that referenced this issue Jun 6, 2017
@jmurty
#11 Achieve order of magnitude speedup of parser
e713c06 
- use faster pyparsing grammar constructs and
  arrangements to significantly speed up parsing
- enable skipped parsing unit tests now that they
  are not infeasibly slow
- add testing requirements to setup.py

Anecdotal speed increase is from about 30 seconds
to run the `test_date_values` tests down to below
3 seconds.

See also #17
@jmurty jmurty mentioned this issue Jun 6, 2017
Closed
cogat added a commit that referenced this issue Jun 6, 2017
@cogat
Merge pull request #18 from ixc/11-improve-parser-performance
c9996af 
#11 Achieve order of magnitude speedup of parser
@ahankinson ahankinson mentioned this issue Apr 13, 2021
Closed
@ColeDCrawford ColeDCrawford mentioned this issue May 28, 2024
Merged
5 tasks
@aweakley
Copy link
Member

This is resolved by #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cogat @aweakley