Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux build issues #712

Open
RoySullivan opened this issue Mar 6, 2017 · 12 comments
Open

linux build issues #712

RoySullivan opened this issue Mar 6, 2017 · 12 comments

Comments

@RoySullivan
Copy link

how to fix this? it's from sanghakchun/Polycode branch linux-build-fix

../../src/modules/physics2D/PolyPhysicsScreen.cpp: In constructor ‘Polycode::PhysicsScene2D::PhysicsScene2D()’:
../../src/modules/physics2D/PolyPhysicsScreen.cpp:198:57: error: invalid conversion from ‘int’ to ‘Polycode::Core*’ [-fpermissive]
PhysicsScene2D::PhysicsScene2D() : Scene(Scene::SCENE_2D) {
^
In file included from ../../include/polycode/modules/physics2D/PolyPhysicsScreen.h:26:0,
from ../../src/modules/physics2D/PolyPhysicsScreen.cpp:24:
../../include/polycode/core/PolyScene.h:61:3: note: initializing argument 1 of ‘Polycode::Scene::Scene(Polycode::Core*)’
Scene(Core core);
^
../../src/modules/physics2D/PolyPhysicsScreen.cpp: In constructor ‘Polycode::PhysicsScene2D::PhysicsScene2D(Number, int, int)’:
../../src/modules/physics2D/PolyPhysicsScreen.cpp:202:111: error: invalid conversion from ‘int’ to ‘Polycode::Core
’ [-fpermissive]
ber worldScale, int velIterations, int posIterations): Scene(Scene::SCENE_2D) {
^
In file included from ../../include/polycode/modules/physics2D/PolyPhysicsScreen.h:26:0,
from ../../src/modules/physics2D/PolyPhysicsScreen.cpp:24:
../../include/polycode/core/PolyScene.h:61:3: note: initializing argument 1 of ‘Polycode::Scene::Scene(Polycode::Core*)’
Scene(Core *core);
^
Makefile:55: recipe for target '../../src/modules/physics2D/PolyPhysicsScreen.o' failed
make: *** [../../src/modules/physics2D/PolyPhysicsScreen.o] Error 1

@zeebok
Copy link

zeebok commented Mar 10, 2017

Is this a straight clone of his repo? I can't vouch for that, but if you pull Ivan's repo, checkout the goodbye_cmake branch, and then pull in sanghakchun's merge request that should work. That's how I got myself up and running.

@RoySullivan
Copy link
Author

@zeebok i forked goodbye_cmake and pull merge with sanghakchun linux-build-fix branch, still giving me the same previous errors like missing files that i have to copy from the master branch, i also had to apply this fodinabor@e59fbe3

but other problems emerge like this:
from ../../src/modules/physics3D/PolyPhysicsScene.cpp:27:
../../include/polycode/modules/physics3D/PolyCollisionScene.h:90:76: error: ISO C++ forbids declaration of ‘PhysicsScene’ with no type [-fpermissive]
PhysicsScene(Core* core, int maxSubSteps = 0, Vector3 size = Vector3(200));

am i doing something wrong?

@zeebok
Copy link

zeebok commented Mar 14, 2017

Ah I haven't applied fodinabor's patch yet, let me take a look.

@zeebok
Copy link

zeebok commented Mar 17, 2017

I am assuming you're trying to compile using make all ? Using fodinabor's branch and the linux build fix, Physics3D should build. I am getting errors for Physics2D but I don't think that was suppose to be fixed on fodinabor's branch so I am not surprised by that.

You should be able to just download fodi's branch and then apply the linux build fix; it seems to be up-to-date with Ivan's branch.

@RoySullivan
Copy link
Author

yeah doing that compiles Physics3D, so does sanghakchun/Polycode nuevo branch, but still the same problems with Physics2D persist.

@fodinabor
Copy link
Contributor

I think the Physics2D is not updated yet...

@RoySullivan
Copy link
Author

@fodinabor yeah, should i close this issues, since it's technically not an issue?

@fodinabor
Copy link
Contributor

well the issue is rather that Physics2D is not up-to-date - if you wish you can create a new issue for this and close this one..

@ghost
Copy link

ghost commented Mar 24, 2017

I just cant understand why someone with experience in polycode cant make a pull request with working build system.

@fodinabor
Copy link
Contributor

fodinabor commented Mar 24, 2017

The build system (system specific) should be working? What do you mean?

@zeebok
Copy link

zeebok commented Mar 25, 2017

I think he means the pull request for the linux build not being able to fix/compile all of the modules as well as fixing the core framework

@ghost
Copy link

ghost commented Mar 25, 2017

@zeebok , exactly. I thought I was clear enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants